Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtletctl gen #642

Merged
merged 16 commits into from
Apr 4, 2018
Merged

Add virtletctl gen #642

merged 16 commits into from
Apr 4, 2018

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Mar 28, 2018

This PR includes a commit from #645 which needs to be merged first.

  • bump k8s libs to 1.9 so MountPropagation field can be set in k8s objects
  • embed virtlet-ds.yaml using bindata
  • check bindata consistency during build/cmd.sh build
  • implement virtletctl gen command
  • update build/cmd.sh start-dind to use virtletctl gen
  • embed image tag in virtletctl when doing release builds on CircleCI
  • update demo.sh to use virtletctl from mirantis/virtlet image (pass selected image tag to it using --tag)
  • remove jq from the build container
  • fix style issues
  • split the part that updates k8s libs into a separate PR
  • update docs
  • verify build/cmd.sh release which no longer includes yamls
  • verify raw_devices setting in virtlet config
  • verify VIRTLET_DISABLE_KVM=1 build/cmd.sh start-dind

This change is Reviewable

@ivan4th ivan4th force-pushed the ivan4th/yaml-gen branch 2 times, most recently from 5f3f0c4 to 160864c Compare April 2, 2018 13:24
@ivan4th ivan4th mentioned this pull request Apr 2, 2018
@ivan4th ivan4th force-pushed the ivan4th/yaml-gen branch 2 times, most recently from b0ff3cf to 4d88ebd Compare April 3, 2018 02:12
@ivan4th ivan4th changed the title [WiP] Add virtletctl gen Add virtletctl gen Apr 3, 2018
@jellonek
Copy link
Contributor

jellonek commented Apr 3, 2018

Reviewed 26 of 31 files at r1, 31 of 31 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


deploy/README.md, line 55 at r2 (raw file):

1. Wait for Virtlet pod to activate:

kubectl get pods -w -n kube-system

This deserves for a follow up in shape of additional subcommand for virtletctl or option --wait or similar for version subcommand.
Will describe that in an issue.


docs/networking.md, line 105 at r2 (raw file):

In case if standard Virtlet deployment yaml is used (generated using
`virtletctl gen`), this can be done by `settingsriov_support=true` in

There was a typo - missing space after setting. So that should be "setting `sriov_...".


Comments from Reviewable

@ivan4th
Copy link
Contributor Author

ivan4th commented Apr 3, 2018

Review status: 43 of 44 files reviewed at latest revision, 1 unresolved discussion.


docs/networking.md, line 105 at r2 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

There was a typo - missing space after setting. So that should be "setting `sriov_...".

Done.


Comments from Reviewable

@jellonek
Copy link
Contributor

jellonek commented Apr 3, 2018

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jellonek
Copy link
Contributor

jellonek commented Apr 4, 2018

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@lukaszo
Copy link
Contributor

lukaszo commented Apr 4, 2018

Review status: 29 of 37 files reviewed at latest revision, all discussions resolved.


deploy/real-cluster.md, line 37 at r4 (raw file):

After that, you need to get `virtletctl` command line tool (replace `N.N.N` in the command below accordingly):

curl -SL -o virtletctl https://github.com/Mirantis/virtlet/releases/download/vN.N.N/virtletctl

is it possible to have here latest version?


Comments from Reviewable

@ivan4th
Copy link
Contributor Author

ivan4th commented Apr 4, 2018

Review status: 27 of 37 files reviewed at latest revision, 1 unresolved discussion.


deploy/real-cluster.md, line 37 at r4 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

is it possible to have here latest version?

Added the notes about it below.


Comments from Reviewable

@lukaszo
Copy link
Contributor

lukaszo commented Apr 4, 2018

:lgtm:


Reviewed 5 of 31 files at r1, 21 of 31 files at r2, 1 of 1 files at r3, 8 of 9 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@jellonek
Copy link
Contributor

jellonek commented Apr 4, 2018

Review status: all files reviewed at latest revision, 1 unresolved discussion.


deploy/README.md, line 57 at r5 (raw file):

cp _output/virtletctl /usr/local/bin

Another way is to use the latest released virtletctl with --tag latest, see below.

virtletctl


deploy/README.md, line 67 at r5 (raw file):

Note thought that it'll only work if the generated yaml didn't change between
virtletctl version and the image tag you specified, so your mileage may vary.

virtletctl


deploy/real-cluster.md, line 44 at r5 (raw file):

If you want to use the latest image, you can build virtletctl yourself from the source:

virtletctl


deploy/real-cluster.md, line 52 at r5 (raw file):

cp _output/virtletctl /usr/local/bin

Another way is to use the latest released virtletctl with --tag latest, see below.

virtletctl


Comments from Reviewable

@jellonek
Copy link
Contributor

jellonek commented Apr 4, 2018

:lgtm:


Reviewed 8 of 9 files at r4, 2 of 2 files at r6.
Review status: all files reviewed at latest revision, 5 unresolved discussions.


Comments from Reviewable

@jellonek jellonek merged commit f1fe2fb into master Apr 4, 2018
@jellonek jellonek deleted the ivan4th/yaml-gen branch April 4, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants