-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtletctl gen #642
Add virtletctl gen #642
Conversation
5f3f0c4
to
160864c
Compare
b0ff3cf
to
4d88ebd
Compare
Reviewed 26 of 31 files at r1, 31 of 31 files at r2. deploy/README.md, line 55 at r2 (raw file):
This deserves for a follow up in shape of additional subcommand for docs/networking.md, line 105 at r2 (raw file):
There was a typo - missing space after setting. So that should be "setting `sriov_...". Comments from Reviewable |
4d88ebd
to
0ed52b8
Compare
Review status: 43 of 44 files reviewed at latest revision, 1 unresolved discussion. docs/networking.md, line 105 at r2 (raw file): Previously, jellonek (Piotr Skamruk) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
0ed52b8
to
90e9461
Compare
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Review status: 29 of 37 files reviewed at latest revision, all discussions resolved. deploy/real-cluster.md, line 37 at r4 (raw file):
is it possible to have here Comments from Reviewable |
Review status: 27 of 37 files reviewed at latest revision, 1 unresolved discussion. deploy/real-cluster.md, line 37 at r4 (raw file): Previously, lukaszo (Łukasz Oleś) wrote…
Added the notes about it below. Comments from Reviewable |
Reviewed 5 of 31 files at r1, 21 of 31 files at r2, 1 of 1 files at r3, 8 of 9 files at r4, 2 of 2 files at r5. Comments from Reviewable |
Review status: all files reviewed at latest revision, 1 unresolved discussion. deploy/README.md, line 57 at r5 (raw file):
deploy/README.md, line 67 at r5 (raw file):
deploy/real-cluster.md, line 44 at r5 (raw file):
deploy/real-cluster.md, line 52 at r5 (raw file):
Comments from Reviewable |
8196fff
to
691c191
Compare
Reviewed 8 of 9 files at r4, 2 of 2 files at r6. Comments from Reviewable |
Embed virtlet-ds.yaml using bindata
691c191
to
abc5955
Compare
This PR includes a commit from #645 which needs to be merged first.
MountPropagation
field can be set in k8s objectsvirtlet-ds.yaml
using bindatabuild/cmd.sh build
virtletctl gen
commandbuild/cmd.sh start-dind
to usevirtletctl gen
demo.sh
to usevirtletctl
frommirantis/virtlet
image (pass selected image tag to it using--tag
)jq
from the build containerbuild/cmd.sh release
which no longer includes yamlsraw_devices
setting in virtlet configVIRTLET_DISABLE_KVM=1 build/cmd.sh start-dind
This change is