Documentation for multiple interfaces #654

lukaszo · 2018-04-12T08:55:21Z

This change is

jellonek · 2018-04-12T10:41:40Z

Reviewed 2 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, all discussions resolved.

docs/multiple-interfaces.md, line 3 at r1 (raw file):

# Overview

Virtlet, as all Kuberentes runtimes, is using CNI plugins to configure network interface.

Whitespace at EOL. That means you have misconfigured editor ;)

docs/multiple-interfaces.md, line 4 at r1 (raw file):

Virtlet, as all Kuberentes runtimes, is using CNI plugins to configure network interface. 
Thanks to [CNI-Genie](https://github.com/Huawei-PaaS/CNI-Genie) Virtlet can use multiple plugins in one pod which results in multiple interfaces.

... multiple CNI plugins to configure networking in a pod which results ...

docs/multiple-interfaces.md, line 9 at r1 (raw file):

* forked CNI Genie, docker image: `mirantis/cnigenie`
* preinstalled CNI plugins in version 0.6.0

So probably 0.7.1 will be better at the moment? :D

docs/multiple-interfaces.md, line 10 at r1 (raw file):

* forked CNI Genie, docker image: `mirantis/cnigenie`
* preinstalled CNI plugins in version 0.6.0
* `cniVersion` for all plugins set to at least `0.3.0`

cniVersion set to at least 0.3.0 in all configuration files for CNI networks (look on examples below)

btw. these configs are for configuring particular named networks, using selected plugins - so it's not so correct to call that as "plugin configuration".

docs/multiple-interfaces.md, line 12 at r1 (raw file):

* `cniVersion` for all plugins set to at least `0.3.0`

### CNI-genie

Why third level instead of second?

docs/multiple-interfaces.md, line 14 at r1 (raw file):

### CNI-genie

There are two ways to tell CNI Genie which CNI plugins to use:

which CNI networks to use

docs/multiple-interfaces.md, line 15 at r1 (raw file):

There are two ways to tell CNI Genie which CNI plugins to use:
* by setting a `cni: <plugins list>` in pods annotation

Hmmm... maybe there should be an info how <plugin list> should look like? I mean - that it should be enclosed in "" and that should be comma separated list without spaces?
For now its form is only noted in updating cni genie defaults, so it's not clear what should be set there.
And again - it's not a list of plugins. Same plugin can be reused by multiple network configs.
Also I don't see anywhere info about what is an element of this list (part of name of network config file).

docs/multiple-interfaces.md, line 18 at r1 (raw file):

* by setting `default_plugin` option in CNI Genie configuration file

### Configuring plugins

Same question as above about level.
Also "Configuring networks".

docs/multiple-interfaces.md, line 19 at r1 (raw file):

### Configuring plugins
CNI plugins should return result in 0.3.0 format. All config files should be updated

... result in format 0.3.0 or later.
Missing dot at the EOL.

docs/multiple-interfaces.md, line 24 at r1 (raw file):

## Start Kubernetes 1.9 cluster with Flannel, Calico and CNI-Genie

This and most quotes below should be marked as bash source using:

docs/multiple-interfaces.md, line 164 at r1 (raw file):

Troubleshooting

Space at EOL.

examples/ubuntu-multi-cni.yaml, line 6 at r1 (raw file):

  name: ubuntu-vm
  annotations:
    multi-ip-preferences: |

Would be nice to have that commented. Also IMO it deserves for a description in main doc, how to interpret data which is set there by genie.
Afair it's optional - this probably also should be noted.

Comments from Reviewable

ologvinova · 2018-04-12T10:49:43Z

Review status: 1 of 2 files reviewed at latest revision, 12 unresolved discussions.

docs/multiple-interfaces.md, line 4 at r1 (raw file):

Virtlet

, Virtlet

docs/multiple-interfaces.md, line 15 at r1 (raw file):

remove

docs/multiple-interfaces.md, line 16 at r1 (raw file):

setting

setting the

docs/multiple-interfaces.md, line 29 at r1 (raw file):

D

docs/multiple-interfaces.md, line 33 at r1 (raw file):

S

docs/multiple-interfaces.md, line 33 at r1 (raw file):

F

docs/multiple-interfaces.md, line 37 at r1 (raw file):

C

docs/multiple-interfaces.md, line 48 at r1 (raw file):

Setting

(Optional) Set

docs/multiple-interfaces.md, line 48 at r1 (raw file):

 This is optional step.

remove

docs/multiple-interfaces.md, line 52 at r1 (raw file):

Setting

Set

docs/multiple-interfaces.md, line 52 at r1 (raw file):

flannel, calico and genie

Flannel, Calico, and CNI-Genie?

docs/multiple-interfaces.md, line 65 at r1 (raw file):

test vm

a test VM

docs/multiple-interfaces.md, line 69 at r1 (raw file):

 

,

docs/multiple-interfaces.md, line 69 at r1 (raw file):

login using

log in using the

docs/multiple-interfaces.md, line 73 at r1 (raw file):

similar to

for example

docs/multiple-interfaces.md, line 91 at r1 (raw file):

Here is how CNI configuration files looks after changes:

See below examples of the CNI configuration files after changes:

docs/multiple-interfaces.md, line 166 at r1 (raw file):

interfaces please gather all logs from virtlet

interfaces, gather all logs from the Virtlet pod

docs/multiple-interfaces.md, line 172 at r1 (raw file):

many changes we already [did](https://github.com/Huawei-PaaS/CNI-Genie/commits?author=lukaszo)

and we already did many changes.

Comments from Reviewable

jellonek · 2018-04-12T10:53:44Z

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 30 unresolved discussions.

docs/multiple-interfaces.md, line 29 at r1 (raw file):

delete previous cluster if any

Missing : at the end. Same for other examples below.

Comments from Reviewable

lukaszo · 2018-04-12T11:18:14Z

Review status: all files reviewed at latest revision, 31 unresolved discussions.

examples/ubuntu-multi-cni.yaml, line 6 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Would be nice to have that commented. Also IMO it deserves for a description in main doc, how to interpret data which is set there by genie.
Afair it's optional - this probably also should be noted.

I was thinking about it, but this is not a CNI-Genie doc and I decided not to comment it

Comments from Reviewable

jellonek · 2018-04-12T11:26:06Z

Review status: all files reviewed at latest revision, 31 unresolved discussions.

examples/ubuntu-multi-cni.yaml, line 6 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

I was thinking about it, but this is not a CNI-Genie doc and I decided not to comment it

So, maybe only url to genie docs describing the meaning of this section?

Comments from Reviewable

lukaszo · 2018-04-12T14:25:50Z

Review status: all files reviewed at latest revision, 31 unresolved discussions.

docs/multiple-interfaces.md, line 3 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Whitespace at EOL. That means you have misconfigured editor ;)

Done.

docs/multiple-interfaces.md, line 4 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

... multiple CNI plugins to configure networking in a pod which results ...

Done.

docs/multiple-interfaces.md, line 4 at r1 (raw file):

Previously, ologvinova wrote…

Virtlet
, Virtlet

Done.

docs/multiple-interfaces.md, line 9 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

So probably 0.7.1 will be better at the moment? :D

No idea. I didn't check which one is better. I'm just listening what's supported.

docs/multiple-interfaces.md, line 10 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

cniVersion set to at least 0.3.0 in all configuration files for CNI networks (look on examples below)

btw. these configs are for configuring particular named networks, using selected plugins - so it's not so correct to call that as "plugin configuration".

Done.

docs/multiple-interfaces.md, line 12 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Why third level instead of second?

Done.

docs/multiple-interfaces.md, line 15 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Hmmm... maybe there should be an info how <plugin list> should look like? I mean - that it should be enclosed in "" and that should be comma separated list without spaces?
For now its form is only noted in updating cni genie defaults, so it's not clear what should be set there.
And again - it's not a list of plugins. Same plugin can be reused by multiple network configs.
Also I don't see anywhere info about what is an element of this list (part of name of network config file).

I don't want it to be a CNI-Genie documentation. I will link to it's doc at beginning. I'm also adding yaml file with an example

docs/multiple-interfaces.md, line 16 at r1 (raw file):

Previously, ologvinova wrote…

setting
setting the

Done.

docs/multiple-interfaces.md, line 18 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Same question as above about level.
Also "Configuring networks".

Done.

docs/multiple-interfaces.md, line 24 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

This and most quotes below should be marked as bash source using:

</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 29 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tQIw_63kPjRHqYCQC:-L9uCjSu7Q3bMJpXDoZ7:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L29)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> d
> ```
D
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 29 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tTxRtD05010LSvG88:-L9uCqsjC2aXs-5AjBC6:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L29)):*
<details><summary><i>Previously, jellonek (Piotr Skamruk) wrote…</i></summary><blockquote>

Missing `:` at the end. Same for other examples below.
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 33 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tQKiY5arfHRMZmn52:-L9uCtP80oTqXeqDta6c:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L33)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> s
> ```
S
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 33 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tQNDaEXr0Bx5o546N:-L9uCuA404tanqNSwBrZ:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L33)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> f
> ```
F
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 37 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tQP6g7n17Sgl55biU:-L9uCulxCCetuW6LIV-_:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L37)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> c
> ```
C
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 48 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tQcOFBpS9Nwzc6u5P:-L9uD1SS803co-nq_pDt:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L48)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> Setting
> ```
(Optional) Set
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 48 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tTLuV8g1Ex1nHnkLr:-L9uD1o9Cdvv5GmSBTIc:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L48)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
>  This is optional step.
> ```
remove
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 52 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tQg-g5voXRVDIlHfR:-L9uD6-iDEo6tDRw-k7a:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L52)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> Setting
> ```
Set
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 65 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tQwU_0dEvGCMjmJNb:-L9uDDXhA8d6O2iijk8G:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L65)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> test vm
> ```
a test VM
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 69 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tR4kqEFURwrzSA3fk:-L9uEawa6LXnYcUUmbaU:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L69)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> login using
> ```
log in using the
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 69 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tR2C30xqkK3ZbYbU3:-L9uEcko56aETwr2FwI7:b32vlc) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L69)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
>  
> ```
,
</blockquote></details>

?

---

*[docs/multiple-interfaces.md, line 73 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tRBiG-5nd6p3eNI2K:-L9uEaKBA4wDNZWamoaR:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L73)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> similar to
> ```
for example
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 91 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tRZui-FRGBH5JEDgI:-L9uE_nk8JhpYqBHFna-:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L91)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> Here is how CNI configuration files looks after changes:
> ```
See below examples of the CNI configuration files after changes:
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 164 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tRCiN1SOZnqRLLhHh:-L9uE_5N-xUfHlZiJtOX:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L164)):*
<details><summary><i>Previously, jellonek (Piotr Skamruk) wrote…</i></summary><blockquote>

Space at EOL.
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 166 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tRtiFDj_c1pZ29Nqf:-L9uEZDI6LWAgN1cZWaw:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L166)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> interfaces please gather all logs from virtlet
> ```
interfaces, gather all logs from the Virtlet pod
</blockquote></details>

Done.

---

*[docs/multiple-interfaces.md, line 172 at r1](https://beta.reviewable.io/reviews/mirantis/virtlet/654#-L9tS8uy96jTykjsoJWo:-L9uEZW5ClW8udcMappq:b-896fix) ([raw file](https://github.com/mirantis/virtlet/blob/585078937efac367024fce42305887dad40e2ee8/docs/multiple-interfaces.md#L172)):*
<details><summary><i>Previously, ologvinova wrote…</i></summary><blockquote>

> ```
> many changes we already [did](https://github.com/Huawei-PaaS/CNI-Genie/commits?author=lukaszo)
> ```
and we already did many [changes](https://github.com/Huawei-PaaS/CNI-Genie/commits?author=lukaszo).
</blockquote></details>

Done.

---


*Comments from [Reviewable](https://beta.reviewable.io/reviews/mirantis/virtlet/654)*
<!-- Sent from Reviewable.io -->

ologvinova · 2018-04-13T14:58:10Z

Review status: 1 of 2 files reviewed at latest revision, 31 unresolved discussions.

Comments from Reviewable

jellonek · 2018-04-13T15:07:32Z

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 20 unresolved discussions.

docs/multiple-interfaces.md, line 24 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

Done.

Not in this exact place but I see that below.

docs/multiple-interfaces.md, line 69 at r1 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

?

Probably missing "," after "after that", but lets wait for Olena.

Comments from Reviewable

ologvinova · 2018-04-13T15:09:07Z

Review status: all files reviewed at latest revision, 20 unresolved discussions.

docs/multiple-interfaces.md, line 14 at r3 (raw file):

continuing please check a

you proceed, read the

docs/multiple-interfaces.md, line 25 at r3 (raw file):

 

a

docs/multiple-interfaces.md, line 25 at r3 (raw file):

 

comma

docs/multiple-interfaces.md, line 35 at r3 (raw file):

 

the

docs/multiple-interfaces.md, line 50 at r3 (raw file):

Setting

Set

docs/multiple-interfaces.md, line 71 at r3 (raw file):

 

comma

docs/multiple-interfaces.md, line 96 at r3 (raw file):

## CNI Genie
File `/etc/cni/net.d/00-genie.conf`

colon (:)

docs/multiple-interfaces.md, line 119 at r3 (raw file):

Calico

File /etc/cni/net.d/10-calico.conf

colon

docs/multiple-interfaces.md, line 173 at r3 (raw file):

many changes

remove

Comments from Reviewable

ologvinova · 2018-04-13T15:19:44Z

Review status: all files reviewed at latest revision, 29 unresolved discussions.

docs/multiple-interfaces.md, line 69 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Probably missing "," after "after that", but lets wait for Olena.

Sorry for confusion, yes I meant a comma after "that". Thanks Piotr.

Comments from Reviewable

ivan4th · 2018-04-13T15:24:21Z

Review status: all files reviewed at latest revision, 29 unresolved discussions.

docs/multiple-interfaces.md, line 57 at r3 (raw file):

```bash
docker exec kube-node-1 bash -c "jq '.cniVersion=\"0.3.0\"' /etc/cni/net.d/10-calico.conf > /tmp/calico.tmp && mv /tmp/calico.tmp /etc/cni/net.d/10-calico.conf"
docker exec kube-node-1 bash -c "jq '.cniVersion=\"0.3.0\"' /etc/cni/net.d/10-flannel.conflist > /tmp/flannel.tmp && mv /tmp/flannel.tmp /etc/cni/net.d/10-flannel.conflist"

I was also using something like del(.ipam.gateway,.ipam.routes)|.cniVersion|=\"0.3.0\" for non-primary CNI, is this not needed anymore?

Comments from Reviewable

ologvinova · 2018-04-13T15:50:14Z

Review status: all files reviewed at latest revision, 30 unresolved discussions.

docs/multiple-interfaces.md, line 25 at r3 (raw file):

Start Kubernetes 1.9

Start a Kubernetes 1.9

docs/multiple-interfaces.md, line 25 at r3 (raw file):

Calico and CNI-Genie

Calico, and CNI-Genie.

docs/multiple-interfaces.md, line 35 at r3 (raw file):

Start cluster

Start a cluster

docs/multiple-interfaces.md, line 67 at r3 (raw file):

test VM

a test VM.

docs/multiple-interfaces.md, line 96 at r3 (raw file):

`/etc/cni/net.d/00-genie.conf`

/etc/cni/net.d/00-genie.conf:

docs/multiple-interfaces.md, line 119 at r3 (raw file):

`/etc/cni/net.d/10-calico.conf`

/etc/cni/net.d/10-calico.conf:

docs/multiple-interfaces.md, line 143 at r3 (raw file):

`/etc/cni/net.d/10-flannel.conflist`

/etc/cni/net.d/10-flannel.conflist:

Comments from Reviewable

lukaszo · 2018-04-16T09:13:46Z

Review status: 1 of 2 files reviewed at latest revision, 33 unresolved discussions.

docs/multiple-interfaces.md, line 14 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

which CNI networks to use

Done.

docs/multiple-interfaces.md, line 15 at r1 (raw file):

Previously, ologvinova wrote…

a
remove

Done.

docs/multiple-interfaces.md, line 19 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

... result in format 0.3.0 or later.
Missing dot at the EOL.

Done.

docs/multiple-interfaces.md, line 52 at r1 (raw file):

Previously, ologvinova wrote…

flannel, calico and genie
Flannel, Calico, and CNI-Genie?

Done.

docs/multiple-interfaces.md, line 14 at r3 (raw file):

Previously, ologvinova wrote…

continuing please check a
you proceed, read the

Done.

docs/multiple-interfaces.md, line 25 at r3 (raw file):

Previously, ologvinova wrote…

Start Kubernetes 1.9
Start a Kubernetes 1.9

Done.

docs/multiple-interfaces.md, line 25 at r3 (raw file):

Previously, ologvinova wrote…

Calico and CNI-Genie
Calico, and CNI-Genie.

Done.

docs/multiple-interfaces.md, line 35 at r3 (raw file):

Previously, ologvinova wrote…

 
the

Done.

docs/multiple-interfaces.md, line 57 at r3 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

I was also using something like del(.ipam.gateway,.ipam.routes)|.cniVersion|=\"0.3.0\" for non-primary CNI, is this not needed anymore?

It's not needed for deployment to success. I'm not sure if it's required later.

docs/multiple-interfaces.md, line 96 at r3 (raw file):

Previously, ologvinova wrote…

`/etc/cni/net.d/00-genie.conf`
/etc/cni/net.d/00-genie.conf:

Done.

docs/multiple-interfaces.md, line 119 at r3 (raw file):

Previously, ologvinova wrote…

`/etc/cni/net.d/10-calico.conf`
/etc/cni/net.d/10-calico.conf:

Done.

docs/multiple-interfaces.md, line 143 at r3 (raw file):

Previously, ologvinova wrote…

`/etc/cni/net.d/10-flannel.conflist`
/etc/cni/net.d/10-flannel.conflist:

Done.

docs/multiple-interfaces.md, line 173 at r3 (raw file):

Previously, ologvinova wrote…

many changes

remove

Done.

Comments from Reviewable

jellonek · 2018-04-16T09:33:39Z

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 32 unresolved discussions.

Comments from Reviewable

ologvinova · 2018-04-16T09:43:19Z

Review status: all files reviewed at latest revision, 32 unresolved discussions.

docs/multiple-interfaces.md, line 25 at r4 (raw file):

with a Flannel,

with Flannel,

docs/multiple-interfaces.md, line 67 at r4 (raw file):

test VM

a test VM

Comments from Reviewable

lukaszo · 2018-04-16T09:45:11Z

Review status: all files reviewed at latest revision, 34 unresolved discussions.

docs/multiple-interfaces.md, line 67 at r4 (raw file):

Previously, ologvinova wrote…

test VM
a test VM

Done.

Comments from Reviewable

ologvinova · 2018-04-16T10:45:22Z

Reviewed 1 of 1 files at r4.
Review status: 1 of 2 files reviewed at latest revision, 34 unresolved discussions.

Comments from Reviewable

pigmej · 2018-04-16T11:46:10Z

Reviewed 1 of 2 files at r1, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 34 unresolved discussions.

Comments from Reviewable

lukaszo changed the title ~~WiP multiple interfaces doc~~ Documentation for multiple interfaces Apr 12, 2018

Document multiple interfaces usage in virtlet [ci skip]

0bc7f2d

pigmej merged commit fa87a6c into Mirantis:master Apr 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Documentation for multiple interfaces #654

Documentation for multiple interfaces #654

lukaszo commented Apr 12, 2018 •

edited by pigmej

Loading

jellonek commented Apr 12, 2018

Troubleshooting

ologvinova commented Apr 12, 2018

jellonek commented Apr 12, 2018

lukaszo commented Apr 12, 2018

jellonek commented Apr 12, 2018

lukaszo commented Apr 12, 2018

ologvinova commented Apr 13, 2018

jellonek commented Apr 13, 2018

ologvinova commented Apr 13, 2018

Calico

ologvinova commented Apr 13, 2018

ivan4th commented Apr 13, 2018

ologvinova commented Apr 13, 2018

lukaszo commented Apr 16, 2018

jellonek commented Apr 16, 2018

ologvinova commented Apr 16, 2018

lukaszo commented Apr 16, 2018

ologvinova commented Apr 16, 2018

pigmej commented Apr 16, 2018

Documentation for multiple interfaces #654

Documentation for multiple interfaces #654

Conversation

lukaszo commented Apr 12, 2018 • edited by pigmej Loading

jellonek commented Apr 12, 2018

Troubleshooting

ologvinova commented Apr 12, 2018

jellonek commented Apr 12, 2018

lukaszo commented Apr 12, 2018

jellonek commented Apr 12, 2018

lukaszo commented Apr 12, 2018

ologvinova commented Apr 13, 2018

jellonek commented Apr 13, 2018

ologvinova commented Apr 13, 2018

Calico

ologvinova commented Apr 13, 2018

ivan4th commented Apr 13, 2018

ologvinova commented Apr 13, 2018

lukaszo commented Apr 16, 2018

jellonek commented Apr 16, 2018

ologvinova commented Apr 16, 2018

lukaszo commented Apr 16, 2018

ologvinova commented Apr 16, 2018

pigmej commented Apr 16, 2018

lukaszo commented Apr 12, 2018 •

edited by pigmej

Loading