Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes-in-Kubernetes example #655

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Apr 16, 2018

Make it work with current kubeadm


This change is Reviewable

@jellonek
Copy link
Contributor

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


examples/README.md, line 44 at r1 (raw file):

Watch progress of the cluster setup via the VM console:

bash


examples/README.md, line 50 at r1 (raw file):

After it's complete you can log into the master node:

bash


examples/README.md, line 62 at r1 (raw file):

kubectl get pods --all-namespaces -o wide -w
# Press Ctrl-C when all the pods are ready

bash


Comments from Reviewable

@lukaszo
Copy link
Contributor

lukaszo commented Apr 16, 2018

:lgtm:


Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Apr 16, 2018

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


Comments from Reviewable

@pigmej pigmej merged commit 957bc6c into master Apr 16, 2018
@pigmej pigmej deleted the ivan4th/update-k-in-k branch April 16, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants