Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vfio-pci instead of pci-assign for SR-IOV devices. #656

Merged
merged 9 commits into from
Apr 18, 2018
Merged

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Apr 16, 2018

This change is Reviewable

@jellonek jellonek force-pushed the jell/vfio branch 7 times, most recently from 62e9a97 to 7d99634 Compare April 17, 2018 07:54
@jellonek jellonek force-pushed the jell/vfio branch 4 times, most recently from 7073ec3 to 7180321 Compare April 17, 2018 10:45
@jellonek jellonek force-pushed the jell/vfio branch 3 times, most recently from f3b2ece to de39bb4 Compare April 17, 2018 11:44
@jellonek jellonek force-pushed the jell/vfio branch 8 times, most recently from 5bdc8e6 to c3fe6e1 Compare April 17, 2018 17:18
@jellonek jellonek changed the title [WIP] Use vfio-pci instead of pci-assign for SR-IOV devices. Use vfio-pci instead of pci-assign for SR-IOV devices. Apr 17, 2018
@ivan4th
Copy link
Contributor

ivan4th commented Apr 18, 2018

Review status: 0 of 12 files reviewed at latest revision, all discussions resolved.


images/image_skel/libvirt.sh, line 22 at r1 (raw file):

    ls -l /sys/class/net/*/device/iommu_group | sed -e "s/.*\//    \"\/dev\/vfio\//" -e "s/\$/\",/"
    tail -n +$((marker_line+1)) /etc/libvirt/qemu.conf.tmpl
  } >/etc/libvirt/qemu.conf

just use # @DEVS@ in qemu.conf instead of using the template file and marker line
then just

files=$(ls /sys/class/net/*/device/iommu_group | sed 's@\(.*\)@/dev/vfio/\1,@')
sed -i "s/.*\(# @DEVS@\)/${files} /dev/vfio/vfio \1/" /etc/libvirt/qemu.conf

pls verify if it works this way, it would be simpler


Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Apr 18, 2018

:lgtm:


Reviewed 10 of 12 files at r1, 2 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Apr 18, 2018

Reviewed 10 of 12 files at r1, 2 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Apr 18, 2018

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Apr 18, 2018

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


a discussion (no related file):
Seems that there is some error during e2e, removing my lgtm


Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Apr 18, 2018

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Apr 18, 2018

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@ivan4th ivan4th merged commit 18977df into master Apr 18, 2018
@ivan4th ivan4th deleted the jell/vfio branch April 18, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants