Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow start of libvirt with sriov_enabled on node without sriov #661

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Apr 19, 2018

Virtlet configmap is common for all nodes, so if different nodes have different hardware we should allow to start Virtlet with set sriov_enabled to non empty value in this config map even if there is missing hardware supporting SR-IOV.

Without this patch - regenerate_qemu_conf will fail because of ls can't find such entry in sysfs.


This change is Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Apr 19, 2018

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


images/image_skel/libvirt.sh, line 17 at r1 (raw file):

function regenerate_qemu_conf() {
  if ls -l /sys/class/net/*/device/iommu_group >/dev/null 2>&1 ; then

why -l here? the output goes to /dev/null...


Comments from Reviewable

@jellonek
Copy link
Contributor Author

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


images/image_skel/libvirt.sh, line 17 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

why -l here? the output goes to /dev/null...

Good catch! Done.


Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Apr 20, 2018

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@lukaszo
Copy link
Contributor

lukaszo commented Apr 23, 2018

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Apr 23, 2018

:lgtm:


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@ivan4th ivan4th merged commit e783f53 into master Apr 23, 2018
@ivan4th ivan4th deleted the jell/libvirt_sh branch April 23, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants