Test for breaking RunPodSandbox by CNI failure

[jellonek]

This change is 

[ivan4th]

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

---

pkg/manager/runtime_test.go, line 347 at r1 (raw file):

}

func (tst *virtletCRITester) expectFailingPodSandbox(config *kubeapi.PodSandboxConfig) {

expectSmth is naming is used for mock methods that set expectations but don't do anything else I think. Maybe runPodSandboxAndExpectError?

---

pkg/manager/runtime_test.go, line 350 at r1 (raw file):

	_, err := tst.invoke("RunPodSandbox", &kubeapi.RunPodSandboxRequest{Config: config}, false)
	if err == nil {
		tst.t.Errorf("expected error from RunPodSanbox but received success")

"didn't get an expected error from RunPodSandbox"

---

pkg/manager/runtime_test.go, line 501 at r1 (raw file):

	sandboxes := criapi.GetSandboxes(1)
	sandboxes[0].Metadata.Uid = "should-fail-cni"
	tst.expectFailingPodSandbox(sandboxes[0])

Does this call produce any output if you add tst.verify() at the end?

---

Comments from Reviewable

[ivan4th]

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

---

pkg/manager/runtime_test.go, line 501 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Does this call produce any output if you add tst.verify() at the end?

Probably tst.verify() should be called in any case to record FDManager calls etc.

---

Comments from Reviewable

[jellonek]

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

---

pkg/manager/runtime_test.go, line 501 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Probably tst.verify() should be called in any case to record FDManager calls etc.

Yes, as there is used recorder .verify() should be called at the end.

---

Comments from Reviewable

[jellonek]

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.

---

pkg/manager/runtime_test.go, line 347 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

expectSmth is naming is used for mock methods that set expectations but don't do anything else I think. Maybe runPodSandboxAndExpectError?

Done.

---

pkg/manager/runtime_test.go, line 350 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

"didn't get an expected error from RunPodSandbox"

Done.

---

pkg/manager/runtime_test.go, line 501 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Yes, as there is used recorder .verify() should be called at the end.

Done.

---

Comments from Reviewable

[ivan4th]

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[lukaszo]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[pigmej]

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

Comments from Reviewable