-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-node config #684
Per-node config #684
Conversation
46b1e37
to
d436f34
Compare
Also, use k8s.io/code-generator for CRDs.
59ec825
to
b27bbe8
Compare
b27bbe8
to
c793f9c
Compare
Standard output includes the CRDs `virtletctl gen --crd` gives CRD-only output Add perms for accessing nodes and CRDs
f2c6b85
to
e9e2dc0
Compare
Make sure config mappings w/o nodeSelector and nodeName apply to all nodes.
014fdc1
to
c940c34
Compare
There are only a minor nits in docs, which imo can be fixed later so Reviewed 123 of 123 files at r1. build/update-codegen.sh, line 11 at r1 (raw file):
this assumes that script is executed in root dir of working copy - it would be nice to add above this line docs/config.md, line 46 at r1 (raw file):
imo docs/config.md, line 51 at r1 (raw file):
If you want to be consistent with double spaces after dots - there is one missing before docs/devel/build-tool.md, line 122 at r1 (raw file):
Please enclose virtletctl with `. Comments from Reviewable |
Reviewed 25 of 123 files at r1. Comments from Reviewable |
Review status: 1 of 2 LGTMs obtained docs/config.md, line 9 at r1 (raw file):
Restart of virtlet after changes should also work? Comments from Reviewable |
Review status: 1 of 2 LGTMs obtained docs/config.md, line 9 at r1 (raw file): Previously, lukaszo (Łukasz Oleś) wrote…
Yes, recreation of pod will cause usage of new values. Comments from Reviewable |
Reviewed 123 of 123 files at r1. Comments from Reviewable |
virtletctl version
which may break)For now, the CRD-related generated code is updated using the following command, which only
works if Go 1.10 is installed locally:
This is to be fixed shortly after we switch to Go 1.10 which is required by k8s code generator, so it'll be done via
build/cmd.sh update-codegen
(and the docs will be updated accordingly).This change is