Pass system uuid as domain uuid and in sysinfo #714

jellonek · 2018-07-10T13:10:37Z

This change is

jellonek · 2018-07-10T13:13:09Z

First of commits is also separated to #713

stale · 2018-08-28T07:56:40Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

CLAassistant · 2019-01-14T16:05:04Z

All committers have signed the CLA.

ivan4th

👍 for including the tests!

Reviewed 7 of 10 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @jellonek)

docs/resource_managment.md, line 23 at r1 (raw file):

As Kubelet uses cAdvisor to collect metrics about running containers and Virtlet doesn't create container per each VM, and instead spawns VMs inside Virtlet container. This leads to all the resource usage being lumped together and ascribed to Virtlet pod.

## Setting a particular value for System UUID

Using fixed SMBIOS UUID

docs/resource_managment.md, line 24 at r1 (raw file):

## Setting a particular value for System UUID
By default each VM pod will have autogenerated value for System UUID.  Some images can expect it to have a predictible value e.g.

By default, VM pods use autogenerated SMBIOS UUID values. Some images may expect it to have a fixed value, for example, due to software license requirements. In such cases, the value of SMBIOS UUID can be passed using VirtletSystemUUID annotation.

docs/resource_managment.md, line 34 at r1 (raw file):

Note: single instance of Virtlet can handle only single instance of VM pod with a particular value for System UUID setting.  That means
there can not be multiple VM pods on the same node with the same value of System UUID.  In the same time VM pods with the same value
of SystemUUID can coexist in the same cluster when started (e.g. using DaemonSet) once per node.

Note: Virtlet can't handle multiple VMs with the same SMBIOS UUID on the same node. There can be multiple VM pods with the same SMBIOS UUIDs residing on different nodes in the cluster, though.

pkg/metadata/types/annotations.go, line 121 at r1 (raw file):

	// SystemUUID specifies particular uuid to use as system UUID
	// in domain definition.  If not set - new one will be generated
	// basing on pod id.

SystemUUID specifies fixed SMBIOS UUID to be used for the domain.
If not set, the SMBIOS UUID will be automatically generated from the Pod ID.

pkg/metadata/types/annotations.go, line 315 at r1 (raw file):

		var err error
		if va.SystemUUID, err = uuid.ParseHex(systemUUIDStr); err != nil {
			return fmt.Errorf("failed to parse %q as system uuid: %v", systemUUIDStr, err)

as a UUID

tests/e2e/systemuuid_test.go, line 48 at r1 (raw file):

	scheduleWaitSSH(&vm, &ssh)

	It("Should have particular System UUID set [Conformance]", func() {

Should have the specified SMBIOS UUID set [Conformance]

jellonek

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @ivan4th)

docs/resource_managment.md, line 23 at r1 (raw file):