Support Kubernetes 1.11 #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan4th
force-pushed
the
ivan4th/k8s-1.11
branch
from
29630de
to
ec28c80
Compare
ivan4th
force-pushed
the
ivan4th/k8s-1.11
branch
2 times, most recently
from
a24e6c2
to
e2183bf
Compare
added 2 commits
July 31, 2018 21:50
This fixes CRD validation problem during `kubectl apply` in k8s 1.11
ivan4th
force-pushed
the
ivan4th/k8s-1.11
branch
from
e2babe4
to
68be5be
Compare
ivan4th
force-pushed
the
ivan4th/k8s-1.11
branch
from
68be5be
to
6560896
Compare
There seem to be flakes, concerning the multi-node config in particular.
jellonek
suggested changes
Aug 1, 2018
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status: 0 of 2 LGTMs obtained
.circleci/config.yml, line 367 at r1 (raw file):
# e2e_1_9: # <<: *e2e
Commented remains. Should be removed?
.circleci/config.yml, line 478 at r1 (raw file):
# tags: # only: # - /^v[0-9].*/
As above.
jellonek
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained, and 1 stale
.circleci/config.yml, line 367 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Commented remains. Should be removed?
So it's because of flakes - ok.
pigmej
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1.
Reviewable status: 1 of 2 LGTMs obtained
pigmej
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo.shandcmd.shThis change is