Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mount entry lack when create and delete virtlet #729

Merged
merged 1 commit into from
Aug 24, 2018
Merged

mount entry lack when create and delete virtlet #729

merged 1 commit into from
Aug 24, 2018

Conversation

yanxuean
Copy link
Contributor

@yanxuean yanxuean commented Jul 27, 2018 •
edited by pigmej
Loading

Signed-off-by: yanxuean yan.xuean@zte.com.cn

I saw plenty of mount entry(/run/libvirt) in host When i create and delete virtlet.

the first create

[root@cloud-test2:~/virtlet]$ mount
sysfs on /sys type sysfs (rw,nosuid,nodev,noexec,relatime)
proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
devtmpfs on /dev type devtmpfs (rw,nosuid,size=8124456k,nr_inodes=2031114,mode=755)
securityfs on /sys/kernel/security type securityfs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /dev/shm type tmpfs (rw,nosuid,nodev)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
tmpfs on /run type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /sys/fs/cgroup type tmpfs (ro,nosuid,nodev,noexec,mode=755)
cgroup on /sys/fs/cgroup/systemd type cgroup (rw,nosuid,nodev,noexec,relatime,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd)
pstore on /sys/fs/pstore type pstore (rw,nosuid,nodev,noexec,relatime)
cgroup on /sys/fs/cgroup/devices type cgroup (rw,nosuid,nodev,noexec,relatime,devices)
cgroup on /sys/fs/cgroup/memory type cgroup (rw,nosuid,nodev,noexec,relatime,memory)
cgroup on /sys/fs/cgroup/net_cls,net_prio type cgroup (rw,nosuid,nodev,noexec,relatime,net_prio,net_cls)
cgroup on /sys/fs/cgroup/perf_event type cgroup (rw,nosuid,nodev,noexec,relatime,perf_event)
cgroup on /sys/fs/cgroup/freezer type cgroup (rw,nosuid,nodev,noexec,relatime,freezer)
cgroup on /sys/fs/cgroup/blkio type cgroup (rw,nosuid,nodev,noexec,relatime,blkio)
cgroup on /sys/fs/cgroup/cpuset type cgroup (rw,nosuid,nodev,noexec,relatime,cpuset)
cgroup on /sys/fs/cgroup/cpu,cpuacct type cgroup (rw,nosuid,nodev,noexec,relatime,cpuacct,cpu)
cgroup on /sys/fs/cgroup/pids type cgroup (rw,nosuid,nodev,noexec,relatime,pids)
cgroup on /sys/fs/cgroup/hugetlb type cgroup (rw,nosuid,nodev,noexec,relatime,hugetlb)
configfs on /sys/kernel/config type configfs (rw,relatime)
/dev/mapper/ncl-root on / type xfs (rw,relatime,attr2,inode64,noquota)
systemd-1 on /proc/sys/fs/binfmt_misc type autofs (rw,relatime,fd=28,pgrp=1,timeout=300,minproto=5,maxproto=5,direct)
mqueue on /dev/mqueue type mqueue (rw,relatime)
hugetlbfs on /dev/hugepages type hugetlbfs (rw,relatime)
debugfs on /sys/kernel/debug type debugfs (rw,relatime)
sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw,relatime)
nfsd on /proc/fs/nfsd type nfsd (rw,relatime)
/dev/vda1 on /boot type ext4 (rw,relatime,data=ordered)
/dev/mapper/ncl-root00 on /root type xfs (rw,relatime,attr2,inode64,noquota)
none on /proc/sys/fs/binfmt_misc type binfmt_misc (rw,relatime)
/dev/mapper/ncl-root00 on /root/docker/overlay2 type xfs (rw,relatime,attr2,inode64,noquota)
tmpfs on /run/user/1002 type tmpfs (rw,nosuid,nodev,relatime,size=1626756k,mode=700,uid=1002,gid=1002)
tmpfs on /var/lib/kubelet/pods/fad6d780-90a5-11e8-b3cf-52540031cdce/volumes/kubernetes.io~secret/kube-proxy-token-qc2h6 type tmpfs (rw,relatime)
overlay on /root/docker/overlay2/a4cd45d7d0daefd6651b9d7a672f8f1b3cc1fdb0e020b29a67be28ae8d8dd615/merged type overlay (rw,relatime,lowerdir=l/JLBMPNESSTR2VZ4W2BPPBHGJTE:l/4POQSCPJL5257UCRQPZNZX35OQ,upperdir=a4cd45d7d0daefd6651b9d7a672f8f1b3cc1fdb0e020b29a67be28ae8d8dd615/diff,workdir=a4cd45d7d0daefd6651b9d7a672f8f1b3cc1fdb0e020b29a67be28ae8d8dd615/work)
proc on /run/docker/netns/default type proc (rw,nosuid,nodev,noexec,relatime)
shm on /root/docker/containers/b1a254f3260b6e3a33cb72d43c409d7ba0d3b0475a2d4d2140fa74597928f633/shm type tmpfs (rw,nosuid,nodev,noexec,relatime,size=65536k)
overlay on /root/docker/overlay2/03ac23daf2771590b0978e906adf97d41890afbe23fd26dd21af3efc77fc8c29/merged type overlay (rw,relatime,lowerdir=l/EFLSG5XA3L7JQ4UP2I45CMGXBS:l/A4SABWXZX7PIZGY3WUMPGLM7FD:l/FFQO4L3WVTZF5KKWHEYRWYK2TW:l/HQQU4OQJKWBX5E37V5PSUH3BQD,upperdir=03ac23daf2771590b0978e906adf97d41890afbe23fd26dd21af3efc77fc8c29/diff,workdir=03ac23daf2771590b0978e906adf97d41890afbe23fd26dd21af3efc77fc8c29/work)
tmpfs on /run/docker.sock type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/netns type tmpfs (rw,nosuid,nodev,mode=755)

the first delete

[root@cloud-test2:~/virtlet]$ mount
sysfs on /sys type sysfs (rw,nosuid,nodev,noexec,relatime)
proc on /proc type proc (rw,nosuid,nodev,noexec,relatime)
devtmpfs on /dev type devtmpfs (rw,nosuid,size=8124456k,nr_inodes=2031114,mode=755)
securityfs on /sys/kernel/security type securityfs (rw,nosuid,nodev,noexec,relatime)
tmpfs on /dev/shm type tmpfs (rw,nosuid,nodev)
devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000)
tmpfs on /run type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /sys/fs/cgroup type tmpfs (ro,nosuid,nodev,noexec,mode=755)
cgroup on /sys/fs/cgroup/systemd type cgroup (rw,nosuid,nodev,noexec,relatime,xattr,release_agent=/usr/lib/systemd/systemd-cgroups-agent,name=systemd)
pstore on /sys/fs/pstore type pstore (rw,nosuid,nodev,noexec,relatime)
cgroup on /sys/fs/cgroup/devices type cgroup (rw,nosuid,nodev,noexec,relatime,devices)
cgroup on /sys/fs/cgroup/memory type cgroup (rw,nosuid,nodev,noexec,relatime,memory)
cgroup on /sys/fs/cgroup/net_cls,net_prio type cgroup (rw,nosuid,nodev,noexec,relatime,net_prio,net_cls)
cgroup on /sys/fs/cgroup/perf_event type cgroup (rw,nosuid,nodev,noexec,relatime,perf_event)
cgroup on /sys/fs/cgroup/freezer type cgroup (rw,nosuid,nodev,noexec,relatime,freezer)
cgroup on /sys/fs/cgroup/blkio type cgroup (rw,nosuid,nodev,noexec,relatime,blkio)
cgroup on /sys/fs/cgroup/cpuset type cgroup (rw,nosuid,nodev,noexec,relatime,cpuset)
cgroup on /sys/fs/cgroup/cpu,cpuacct type cgroup (rw,nosuid,nodev,noexec,relatime,cpuacct,cpu)
cgroup on /sys/fs/cgroup/pids type cgroup (rw,nosuid,nodev,noexec,relatime,pids)
cgroup on /sys/fs/cgroup/hugetlb type cgroup (rw,nosuid,nodev,noexec,relatime,hugetlb)
configfs on /sys/kernel/config type configfs (rw,relatime)
/dev/mapper/ncl-root on / type xfs (rw,relatime,attr2,inode64,noquota)
systemd-1 on /proc/sys/fs/binfmt_misc type autofs (rw,relatime,fd=28,pgrp=1,timeout=300,minproto=5,maxproto=5,direct)
mqueue on /dev/mqueue type mqueue (rw,relatime)
hugetlbfs on /dev/hugepages type hugetlbfs (rw,relatime)
debugfs on /sys/kernel/debug type debugfs (rw,relatime)
sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw,relatime)
nfsd on /proc/fs/nfsd type nfsd (rw,relatime)
/dev/vda1 on /boot type ext4 (rw,relatime,data=ordered)
/dev/mapper/ncl-root00 on /root type xfs (rw,relatime,attr2,inode64,noquota)
none on /proc/sys/fs/binfmt_misc type binfmt_misc (rw,relatime)
/dev/mapper/ncl-root00 on /root/docker/overlay2 type xfs (rw,relatime,attr2,inode64,noquota)
tmpfs on /run/user/1002 type tmpfs (rw,nosuid,nodev,relatime,size=1626756k,mode=700,uid=1002,gid=1002)
tmpfs on /var/lib/kubelet/pods/fad6d780-90a5-11e8-b3cf-52540031cdce/volumes/kubernetes.io~secret/kube-proxy-token-qc2h6 type tmpfs (rw,relatime)
overlay on /root/docker/overlay2/a4cd45d7d0daefd6651b9d7a672f8f1b3cc1fdb0e020b29a67be28ae8d8dd615/merged type overlay (rw,relatime,lowerdir=l/JLBMPNESSTR2VZ4W2BPPBHGJTE:l/4POQSCPJL5257UCRQPZNZX35OQ,upperdir=a4cd45d7d0daefd6651b9d7a672f8f1b3cc1fdb0e020b29a67be28ae8d8dd615/diff,workdir=a4cd45d7d0daefd6651b9d7a672f8f1b3cc1fdb0e020b29a67be28ae8d8dd615/work)
proc on /run/docker/netns/default type proc (rw,nosuid,nodev,noexec,relatime)
shm on /root/docker/containers/b1a254f3260b6e3a33cb72d43c409d7ba0d3b0475a2d4d2140fa74597928f633/shm type tmpfs (rw,nosuid,nodev,noexec,relatime,size=65536k)
overlay on /root/docker/overlay2/03ac23daf2771590b0978e906adf97d41890afbe23fd26dd21af3efc77fc8c29/merged type overlay (rw,relatime,lowerdir=l/EFLSG5XA3L7JQ4UP2I45CMGXBS:l/A4SABWXZX7PIZGY3WUMPGLM7FD:l/FFQO4L3WVTZF5KKWHEYRWYK2TW:l/HQQU4OQJKWBX5E37V5PSUH3BQD,upperdir=03ac23daf2771590b0978e906adf97d41890afbe23fd26dd21af3efc77fc8c29/diff,workdir=03ac23daf2771590b0978e906adf97d41890afbe23fd26dd21af3efc77fc8c29/work)
tmpfs on /run/docker.sock type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/netns type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
overlay on /root/docker/overlay2/e521f886ab3be2ef5f20d6ddf48c149337df222e3abf7af0e8acfee434d45afa/merged type overlay (rw,relatime,lowerdir=l/K3AE3YMHCHWLAD7UFUWRGSHNHL:l/4POQSCPJL5257UCRQPZNZX35OQ,upperdir=e521f886ab3be2ef5f20d6ddf48c149337df222e3abf7af0e8acfee434d45afa/diff,workdir=e521f886ab3be2ef5f20d6ddf48c149337df222e3abf7af0e8acfee434d45afa/work)
shm on /root/docker/containers/6af0262c06e7a16e086db52d5f7a1730a22599329719662a95ec4a958270216b/shm type tmpfs (rw,nosuid,nodev,noexec,relatime,size=65536k)
tmpfs on /run/docker.sock type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/docker.sock type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
overlay on /root/docker/overlay2/37ca54c24ddfce97aff1cae178b4c339846c35742c85f321ff97b84a7f67f5c9/merged type overlay (rw,relatime,lowerdir=l/XZ5XFXFQWD6TFLEITEQTXKYSEP:l/2RILS3I3CBOL2HZSKR34N4VIXS:l/2V567HXEMUIBRAVEDZAU4B2F7Q:l/GUTRHQGQE76YBGQLXCVPY2KQYT:l/2KOGDMHZ5KG5IJELMOIIRGVL5K:l/YUTREMIKO3E3W4ABWK3ULF4AR4:l/TBELBPQHTW4LNCNOEVJKL5JPHW:l/QIER5RMJSX2C2SL44QMATH5Y77:l/HXEZTDQRKXKGOSYRADYEKBSIXK:l/AAF24XAUQR3I53B2PMVJGQLCBX:l/7LNTB5GBU73JQKE3MCWNWSTAYB:l/NJ2CIQDAFTBMLDYA7JOPBFXVS3:l/N5V4ULUDR25SUL6NJ5INYTMOLQ:l/5A54CQKDHHLSNYGIQ45Y5P2B2S:l/DBNIRIDJEHOWSYBDCFGMTRG5CN,upperdir=37ca54c24ddfce97aff1cae178b4c339846c35742c85f321ff97b84a7f67f5c9/diff,workdir=37ca54c24ddfce97aff1cae178b4c339846c35742c85f321ff97b84a7f67f5c9/work)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
overlay on /root/docker/overlay2/1256fe1014ad6b9255102ea45ffef31db3272e590cb0bcd5e9ef281a66d03ce1/merged type overlay (rw,relatime,lowerdir=l/OFW3NZETDUQGOUE3G37WNREONC:l/2RILS3I3CBOL2HZSKR34N4VIXS:l/2V567HXEMUIBRAVEDZAU4B2F7Q:l/GUTRHQGQE76YBGQLXCVPY2KQYT:l/2KOGDMHZ5KG5IJELMOIIRGVL5K:l/YUTREMIKO3E3W4ABWK3ULF4AR4:l/TBELBPQHTW4LNCNOEVJKL5JPHW:l/QIER5RMJSX2C2SL44QMATH5Y77:l/HXEZTDQRKXKGOSYRADYEKBSIXK:l/AAF24XAUQR3I53B2PMVJGQLCBX:l/7LNTB5GBU73JQKE3MCWNWSTAYB:l/NJ2CIQDAFTBMLDYA7JOPBFXVS3:l/N5V4ULUDR25SUL6NJ5INYTMOLQ:l/5A54CQKDHHLSNYGIQ45Y5P2B2S:l/DBNIRIDJEHOWSYBDCFGMTRG5CN,upperdir=1256fe1014ad6b9255102ea45ffef31db3272e590cb0bcd5e9ef281a66d03ce1/diff,workdir=1256fe1014ad6b9255102ea45ffef31db3272e590cb0bcd5e9ef281a66d03ce1/work)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/libvirt type tmpfs (rw,nosuid,nodev,mode=755)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
tmpfs on /var/lib/kubelet/pods/8e0d475f-9174-11e8-b87c-52540031cdce/volumes/kubernetes.io~secret/virtlet-token-4mwkb type tmpfs (rw,relatime)
tmpfs on /run/secrets/kubernetes.io/serviceaccount type tmpfs (rw,relatime)
[root@cloud-test2:~/virtlet]$
[root@cloud-test2:~/virtlet]$ mount | grep /run/libvirt | wc -l
63

the second create

[root@cloud-test2:~/virtlet]$ mount | grep /run/libvirt | wc -l
127

This change is Reviewable

@yanxuean yanxuean force-pushed the mountlack branch 4 times, most recently from f45ad40 to 5684b0a Compare July 30, 2018 06:01
@jellonek
Copy link
Contributor

We will verify that on our side - will try to respond quickly on that.

@ivan4th
Copy link
Contributor

ivan4th commented Jul 30, 2018

Thanks for the PR! It's important fix and we're verifying it in our envs. Most likely it's fine but we need to check.

@yanxuean
Copy link
Contributor Author

My host is a variant based on centos7.

[root@cloud-test2:/var/log/pods/aae1f853-9179-11e8-b87c-52540031cdce/virtlet]$ cat /etc/os-release
NAME="NewStart Carrier Grade Server Linux"
VERSION="5"
ID="ZTEOS"
ID_LIKE="rhel fedora"
VERSION_ID="5"
PRETTY_NAME="NewStart Carrier Grade Server Linux"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="http://www.gd-linux.com/"
BUG_REPORT_URL="http://www.gd-linux.com/"

REDHAT_BUGZILLA_PRODUCT="NewStart Carrier Grade Server Linux"
REDHAT_BUGZILLA_PRODUCT_VERSION="5"
REDHAT_SUPPORT_PRODUCT="NewStart Carrier Grade Server Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="5"

[root@cloud-test2:/var/log/pods/aae1f853-9179-11e8-b87c-52540031cdce/virtlet]$ uname -a
Linux cloud-test2 3.10.0-514.6.1.el7.x86_64 #1 SMP Thu Feb 16 19:50:09 CST 2017 x86_64 x86_64 x86_64 GNU/Linux

@yanxuean
mount entry lack when create and delete virtlet
8f5b0cf 
Signed-off-by: yanxuean <yan.xuean@zte.com.cn>
jellonek
jellonek approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: 0 of 2 approvals obtained

ivan4th
ivan4th approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: 1 of 2 approvals obtained

@ivan4th ivan4th merged commit dd19b60 into Mirantis:master Aug 24, 2018
@yanxuean yanxuean deleted the mountlack branch September 6, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan4th ivan4th ivan4th approved these changes

@jellonek jellonek jellonek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanxuean @jellonek @ivan4th