log level: It should be a error log instead of info. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan4th
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 2 approvals obtained (waiting on @ivan4th)
jellonek
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 of 2 approvals obtained (waiting on @ivan4th)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
the function of intercept in file pkg/manager/grpc.go has a condition when invoke handler(crx, req) has a error result, which lead to a log, but the log level is info. It's my suggestion that it should use error log instead of info log. what do you think about?
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #NONE issue
Special notes for your reviewer:
NONE
Release note:
NONE
This change is