Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI metrics - runtime part #743

Merged
merged 12 commits into from
Sep 18, 2018
Merged

CRI metrics - runtime part #743

merged 12 commits into from
Sep 18, 2018

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Aug 20, 2018 •
edited
Loading

TODO:

  • add stats for rootfs filesystem usage of VM
  • add checking for mountpoint of fs on which volumes store is located (that should be included in rootfs stats for each container, but also can be done once per whole filter).

That's final version with additional coverage in pkg/manager/runtime_test.go.

This change is Reviewable

@jellonek jellonek force-pushed the jell/rtstats branch 2 times, most recently from 688134f to cb13ced Compare August 22, 2018 09:24
@jellonek jellonek changed the title [WIP] [PoC] CRI metrics - runtime part [PoC] CRI metrics - runtime part Aug 22, 2018
ivan4th
ivan4th approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 approvals obtained

@jellonek jellonek changed the title [PoC] CRI metrics - runtime part [DNM] [PoC] CRI metrics - runtime part Aug 22, 2018
@jellonek jellonek mentioned this pull request Aug 23, 2018
Closed
@pigmej pigmej added the wip label Aug 31, 2018
@jellonek jellonek changed the title [DNM] [PoC] CRI metrics - runtime part CRI metrics - runtime part Sep 12, 2018
@jellonek jellonek removed the wip label Sep 12, 2018
ivan4th
ivan4th reviewed Sep 18, 2018
View reviewed changes
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 approvals obtained

lukaszo
lukaszo approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@lukaszo lukaszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 approvals obtained

@lukaszo lukaszo merged commit 8638a35 into master Sep 18, 2018
@lukaszo lukaszo deleted the jell/rtstats branch September 18, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan4th ivan4th ivan4th approved these changes

@lukaszo lukaszo lukaszo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jellonek @lukaszo @ivan4th @pigmej