Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example of hostpath and nfs pv/pvc usage #788

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

volume-ji
Copy link
Contributor

@volume-ji volume-ji commented Oct 23, 2018

I Verified the correctness of the filesystem mount, for example hostPath and nfs, adding two example file.


This change is Reviewable

volumeMode: Filesystem
hostPath:
# Use a path that's visible inside the Virtlet pod.
# 9p mode must be supported in host kernel(command: modinfo 9p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Host kernel? Or should that be supported by guest kernel in VM image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, you are right, guest kernel also must support 9p, the example use ubuntu os which support 9p. actually,I want to say that host kernel must install 9p mode.
I shoud modify the annotation as "# 9p mode must be installed in host kernel(command: modinfo 9p)", is ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really needed on host? It's served by qemu which afaik do not uses any part of 9p from host kernel, it implements itself 9p protocol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, you are great again, I used "rmmod 9p" and test again, it works. I change the annotation "# 9p mode must be supported in guest kernel in VM image."

volumeMode: Filesystem
nfs:
# Use a path exposed in nfs server which has a ip 172.21.0.2(command: showmount -e 172.21.0.2)
# 9p mode must be supported in host kernel(command: modinfo 9p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

examples/ubuntu-vm-nfs-pv.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@ivan4th ivan4th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 2 approvals obtained (waiting on @jellonek and @volume-ji)

@jellonek jellonek merged commit e065dc6 into Mirantis:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants