Update k8s example #797
Merged
Update k8s example #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example is updated to make it use "modern" StatefulSet definition and for compatiblity with CoreDNS in k8s 1.12. Previously, the example did work except for the very final stage where kubeconfig is set up for the root user, which was because the script was waiting for DNS pods to become "ready 3/3" instead of "ready 1/1" which must be used for CoreDNS. Also, some unneeded options are removed, and ephemeral flexvolume usage is eliminated in favor of `VirtletRootVolumeSize`.
jellonek
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 2 approvals obtained (waiting on @ivan4th)
examples/k8s.yaml, line 86 at r1 (raw file):
spec: nodeSelector: extraRuntime: virtlet
I think that we should update rest of examples to do that in the same way, using simple nodeSelector instead of more complex affinitity. Will do that in next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example is updated to make it use "modern" StatefulSet definition
and for compatiblity with CoreDNS in k8s 1.12. Previously, the example
did work except for the very final stage where kubeconfig is set up
for the root user, which was because the script was waiting for DNS
pods to become "ready 3/3" instead of "ready 1/1" which must be used
for CoreDNS. Also, some unneeded options are removed, and ephemeral
flexvolume usage is eliminated in favor of
VirtletRootVolumeSize.Docs page that uses the example: http://virtlet.ivan4th.pro/reference/vm-pod/
This change is