Fix loading of image translation CRDs

[ivan4th]

This change is 

[jellonek]

Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @ivan4th)

---

pkg/manager/manager.go, line 64 at r1 (raw file):

// NewVirtletManager creates a new VirtletManager.
func NewVirtletManager(config *v1.VirtletConfig, fdManager tapmanager.FDManager, clientCfg clientcmd.ClientConfig, diagSet *diag.Set) *VirtletManager {
	return &VirtletManager{config: config, fdManager: fdManager, diagSet: diagSet, clientCfg: clientCfg}

That's ok, but imo GetDefaultImageTranslator should return an error on nil clientCfg, instead of skipping crd source.

[ivan4th]

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @jellonek)

---

pkg/manager/manager.go, line 64 at r1 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

That's ok, but imo GetDefaultImageTranslator should return an error on nil clientCfg, instead of skipping crd source.

nil clientCfg is actually used by integration tests that presently don't use CRD based image translation. The integration tests run w/o k8s yet they create an instance of VirtletManager.

[jellonek]

Reviewable status: 1 change requests, 0 of 1 approvals obtained

---

pkg/manager/manager.go, line 64 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

nil clientCfg is actually used by integration tests that presently don't use CRD based image translation. The integration tests run w/o k8s yet they create an instance of VirtletManager.

Ok.

[jellonek]

Reviewable status: complete! 1 of 1 approvals obtained