Fix file injection with multiple partitions and unblock CI #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained
ivan4th
changed the title
ivan4th
force-pushed
the
ivan4th/fix-file-injection-with-multiple-partitions
branch
4 times, most recently
from
c746835
to
213f5b6
Compare
added 4 commits
January 11, 2019 09:16
Most of the time it's not applicable inside the build containers b/c it may be a path on the host, lead to localhost etc.
ivan4th
force-pushed
the
ivan4th/fix-file-injection-with-multiple-partitions
branch
from
213f5b6
to
de46a2f
Compare
ivan4th
changed the title
jellonek
approved these changes
Jan 11, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
jellonek
deleted the
ivan4th/fix-file-injection-with-multiple-partitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix error messages in diskimage code and copyright headers.
This PR also includes the fix for containerd image injection that was
blocking Virtlet CI, as well as related fixes for
build/cmd.sh.This change is