Introduce virtletctl validate command #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellonek
changed the title
ivan4th
approved these changes
Jan 23, 2019
ivan4th
pushed a commit
that referenced
this pull request
Jan 23, 2019
Fixed messages / comments, added some TODOs. Also, don't depened on extraRuntime=virtlet, and always use Virtlet pods (which are found by runtime=virtlet label) to identify Virtlet nodes, so as to have just one way of finding these nodes in virtletctl and not two.
ivan4th
pushed a commit
that referenced
this pull request
Jan 23, 2019
Some improvements for #847. Fix messages / comments, added some TODOs. Also, don't depened on extraRuntime=virtlet, and always use Virtlet pods (which are found by runtime=virtlet label) to identify Virtlet nodes, so as to have just one way of finding these nodes in virtletctl and not two.
ivan4th
pushed a commit
that referenced
this pull request
Jan 23, 2019
Some improvements for #847. Fix messages / comments, added some TODOs. Also, don't depend on extraRuntime=virtlet, and always use Virtlet pods (which are found by runtime=virtlet label) to identify Virtlet nodes, so as to have just one way of finding these nodes in virtletctl and not two.
ivan4th
pushed a commit
that referenced
this pull request
Jan 23, 2019
Some improvements for #847. Fix messages / comments, add some TODOs.
ivan4th
pushed a commit
that referenced
this pull request
Jan 23, 2019
Some improvements for #847. Fix messages / comments, add some TODOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is