Fix Virtlet restarts #867
Fix Virtlet restarts #867
Conversation
Don't depend on CirrOS output messages. Don't use kubectl for Virtlet pod restart tests. Don't try to attach to a VM's console with Stdin enabled (problems due to tty), echo messages to /dev/console instead.
The culprit were cgroups that aren't handled by libvirt. Of those, we already handle hugetlb by moving the emulator process out of it. Still, need to do the same for systemd (name=systemd) and pids cgroup controllers. The problem manifested itself when cgroup-per-qos is enabled for kubelet. This is the default, but in current kdc it may be disabled as a workaround for old kubelet bug. This bug is already fixed, so the workaround is to be removed soon.
Don't store bogus File objects in the metadata db.
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @ivan4th)
tests/e2e/common.go, line 145 at r1 (raw file):
// do asserts that function with multiple return values doesn't fail // Considering we have func `foo(something) (something, error)`
Line above this one is missing a comma if this one should be leaved as was before or period with line below this removed.
Also as extra is now required below example of use is invalid now.
There was a problem hiding this comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @jellonek)
tests/e2e/common.go, line 145 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
Line above this one is missing a comma if this one should be leaved as was before or period with line below this removed.
Also asextrais now required below example of use is invalid now.
Tried to clarify it. And the example is valid, len(extra) != 0 means that the function should return at least 2 values (the last one being the error). The check just makes sure the function isn't called for a function with just one return value (e.g. error)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
This change is