fix(command-handler): only support aliases for ChatInputCommands

only support aliases for ChatInputCommands, instead of applying it to APICommand - breaking load() support for Context Commands due to needing prefixes for concatanation
Mirasaki · Mar 8, 2023 · 35567d8 · 35567d8
1 parent af64f29
commit 35567d8
Showing 1 changed file with 56 additions and 52 deletions.
diff --git a/src/classes/Commands.js b/src/classes/Commands.js
@@ -334,9 +334,6 @@ class ComponentCommand extends CommandBase {
 /**
  * @typedef {Object} APICommandConfig
  * @property {boolean} [global=true] Is the command enabled globally or only in our test-server
- * @property {Array<string>} [aliases=[]] Array of command aliases
- * @property {boolean} [isAlias=false] Indicates if the command is an active alias, you should never have to use this in the constructor, used internally
- * @property {string} [aliasFor='parent_command_name'] The command name this alias is for, you should never have to use this in the constructor, used internally
  */
 
 /**
@@ -357,55 +354,7 @@ class APICommand extends CommandBase {
      * @property {boolean} global Is the command enabled globally or only in our test-server
      */
     this.global = 'global' in config ? config.global : false;
-    /**
-     * @property {Array<string>} aliases Array of command aliases
-     */
-    this.aliases = 'aliases' in config ? config.aliases : [];
-    /**
-     * @property {boolean} isAlias Indicates if the command is an active alias
-     */
-    this.isAlias = 'isAlias' in config ? config.isAlias : false;
-    /**
-     * @property {string | undefined} aliasFor The command name this alias is for
-     */
-    this.aliasFor = 'aliasFor' in config ? config.aliasFor : undefined;
   }
-
-  /**
-   * Register new commands for aliases
-   * @method
-   * @returns {void} Nothing
-   */
-  loadAliases = () => {
-    // Check if we should manage command aliases
-    if (!this.isAlias && this.aliases.length >= 1) {
-      // Looping over all over aliases
-      this.aliases.forEach((alias) => {
-        // Creating the config object for the new command
-        const newCmdConfig = {
-          // spread all properties
-          ...this,
-          data: {
-            ...this.data,
-            name: alias
-            // Overwrite API name after spreading api data
-          },
-          // Transforming the permission level back
-          permLevel: getPermLevelName(this.permLevel),
-          // Setting alias values
-          isAlias: true,
-          aliases: [],
-          aliasFor: this.data.name
-        };
-
-        // Constructing our new command
-        const newCmd = new APICommand(newCmdConfig);
-
-        // Loading the new command
-        newCmd.load(this.filePath, commands);
-      });
-    }
-  };
 }
 
 
@@ -444,6 +393,13 @@ class UserContextCommand extends APICommand {
   }
 }
 
+/**
+ * @typedef {Object} ChatInputCommandConfig
+ * @property {Array<string>} [aliases=[]] Array of command aliases
+ * @property {boolean} [isAlias=false] Indicates if the command is an active alias, you should never have to use this in the constructor, used internally
+ * @property {string} [aliasFor='parent_command_name'] The command name this alias is for, you should never have to use this in the constructor, used internally
+ */
+
 
 /**
  * @extends {APICommand}
@@ -465,7 +421,7 @@ class UserContextCommand extends APICommand {
  */
 class ChatInputCommand extends APICommand {
   /**
-   * @param {BaseConfig | APICommandConfig} config The full command configuration
+   * @param {BaseConfig | APICommandConfig | ChatInputCommandConfig} config The full command configuration
    * @throws {Error} An Error if no `data.description` field is present, as this is required by Discord's API
    */
   constructor (config) {
@@ -477,7 +433,55 @@ class ChatInputCommand extends APICommand {
     if (!this.data.description) {
       throw new Error(`An InteractionCommand description is required by Discord's API\nCommand: ${ this.data.name }`);
     }
+    /**
+     * @property {Array<string>} aliases Array of command aliases
+     */
+    this.aliases = 'aliases' in config ? config.aliases : [];
+    /**
+       * @property {boolean} isAlias Indicates if the command is an active alias
+       */
+    this.isAlias = 'isAlias' in config ? config.isAlias : false;
+    /**
+       * @property {string | undefined} aliasFor The command name this alias is for
+       */
+    this.aliasFor = 'aliasFor' in config ? config.aliasFor : undefined;
   }
+
+  /**
+   * Register new commands for aliases
+   * @method
+   * @returns {void} Nothing
+   */
+  loadAliases = () => {
+    // Check if we should manage command aliases
+    if (!this.isAlias && this.aliases.length >= 1) {
+      // Looping over all over aliases
+      this.aliases.forEach((alias) => {
+        // Creating the config object for the new command
+        const newCmdConfig = {
+          // spread all properties
+          ...this,
+          data: {
+            ...this.data,
+            name: alias
+            // Overwrite API name after spreading api data
+          },
+          // Transforming the permission level back
+          permLevel: getPermLevelName(this.permLevel),
+          // Setting alias values
+          isAlias: true,
+          aliases: [],
+          aliasFor: this.data.name
+        };
+
+        // Constructing our new command
+        const newCmd = new APICommand(newCmdConfig);
+
+        // Loading the new command
+        newCmd.load(this.filePath, commands);
+      });
+    }
+  };
 }
 
 module.exports = {