feature: SyncMethod [Reliable/Unreliable]: Quake Hybrid #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 30, 2024 11:05
MrGadget1024
requested changes
Sep 30, 2024
| @@ -102,6 +103,38 @@ public struct EntityStateMessage : NetworkMessage | |||
| public ArraySegment<byte> payload; | |||
| } | |||
|
|
|||
| // state update for unreliable sync. | |||
| // baseline is always sent over Reliable channel. | |||
| public struct EntityStateMessageUnreliableBaseline : NetworkMessage | |||
There was a problem hiding this comment.
rename to EntityStateMessageReliableBaseline everywhere
There was a problem hiding this comment.
this is for Unreliable SyncMethod, I think it's more obvious this way
There was a problem hiding this comment.
Prove it's not sent on the reliable channel and I'll agree.
There was a problem hiding this comment.
the naming is based on SyncMethod, not on channel.
both ways are possible, but this is more obvious
Comment on lines
+59
to
+61
| public static int unreliableBaselineRate = 1; | ||
| public static float unreliableBaselineInterval => unreliableBaselineRate < int.MaxValue ? 1f / unreliableBaselineRate : 0; // for 1 Hz, that's 1000ms | ||
| static double lastUnreliableBaselineTime; |
There was a problem hiding this comment.
rename to ReliableBaseline everywhere
MrGadget1024
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MERGE #3907 FIRST]
credits to John Carmack for the feat that is the quake networking model.
credits to MrGadget for the hybrid idea to make it scale.