Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(Messages): Use Flags enum for isOwner / IsLocalPlayer #3958

Merged
merged 8 commits into from
Jan 4, 2025

Conversation

MrGadget1024
Copy link
Collaborator

@MrGadget1024 MrGadget1024 commented Dec 22, 2024

Reduces SpawnMessage header by one byte by combining 2 bools into a (byte) Flags enum.

  • isOwner and isLocalPlayer properties for backwards compatibility.

Reduces SpawnMessage header by one byte

Since these are Mirror's internal messages, the Obsoletes may not be necessary, but included for completeness.
@miwarnec miwarnec changed the title fix(Messages): Use Flags enum for isOwner / IsLocalPlayer perf(Messages): Use Flags enum for isOwner / IsLocalPlayer Jan 4, 2025
@miwarnec miwarnec merged commit cb7f990 into master Jan 4, 2025
6 checks passed
@miwarnec miwarnec deleted the AuthorityFlags branch January 4, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants