Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.4's Reworked Broadsword Issues #198

Open
RageTHD opened this issue Aug 5, 2023 · 3 comments
Open

1.4.4's Reworked Broadsword Issues #198

RageTHD opened this issue Aug 5, 2023 · 3 comments
Labels
bug Confirmed bug. enhancement This issue/PR relates to general improvements to the mod.
Milestone

Comments

@RageTHD
Copy link

RageTHD commented Aug 5, 2023

Swords with 1.4.4 slash effect doesn't use Overhaul's melee rework and act as vanilla weapon.
Volcano uses Overhaul's melee rework swinging animations but uses vanilla hitboxes (you can see the particle effect from vanilla swing animations).
Blade of Grass shoots a lot of leaves while using charge attack.

@Mirsario Mirsario added bug Confirmed bug. enhancement This issue/PR relates to general improvements to the mod. labels Aug 5, 2023
@Mirsario Mirsario added this to the 5.0 Release milestone Aug 5, 2023
@NotNihilanth
Copy link

Rapidfire issue also observed on Waffle's Iron, so it's very likely related to the per-swing projectile firing behavior

@RageTHD
Copy link
Author

RageTHD commented Aug 10, 2023

To add to that, MoreZenithItems recently updated some of the weapons and Scythes that use 1.4.4 slash effect also don't work with Overhaul's melee rework. Before the update to MoreZenithItems Overhaul's melee worked like a charm.

@Mirsario
Copy link
Owner

Mirsario commented Sep 7, 2023

Fixes TODO:

  • Fixed the Volcano, Blood Butcherer, and a few other melee weapons using incorrect rotations & locations for their particle effects.
  • Fixed Blade of Grass and projectile-only swords being able to create projectiles during a power attack charge.
  • Fixed the Volcano sword having broken collision checks.
  • Projectile-only swords:
    • Fixed the following projectile-only swords not getting the broadsword overhaul: Night's Edge, Excalibur, True Excalibur, True Night's Edge, Terra Blade, The Horseman's Blade.
    • Fixed projectile-only swords not being fully aimable.
    • Fixed projectile-only swords' swing trail projectiles not flipping with the player's swinging animation.
    • Fixed projectile-only swords not benefiting from velocity-based damage. (Commit above was misnamed, this isn't fixed.)
    • Fixed projectile-only swords not using mana when the Melee.EnableProjectileSwordManaUsage option is enabled.
      • Require and cost mana for the primary swing projectile.
    • Fixed projectile-only swords not being able to perform Killing Blows.
    • Fixed projectile-only swords not supporting air combat.
  • MoreZenithItems mod tested and its swords have no issues.

Mirsario added a commit that referenced this issue Sep 7, 2023
@Mirsario Mirsario changed the title Volcano and Swords with 1.4.4 slash effect aren't using Overhaul's melee rework and Blade of Grass rapid fire leaves when using charge attack 1.4.4's Reworked Broadsword Issues Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug. enhancement This issue/PR relates to general improvements to the mod.
Projects
None yet
Development

No branches or pull requests

3 participants