Some tweaks #1
Open
Some tweaks #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Thanks for your contribution. I'll review it. |
|
@jtellog i have found some time last day to review your commits. I have refactored the directive quite a bit to be more flexible. But your idea about clearing the control is definitively a good one that i will integrate this week. I've asked myself if we can hook up the logic for the form reset (Cancel) too? Any suggestions on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added some simple tweaks to your directive and I would like to contribute back.
-Now when you select a non-image file it will display a feedback message.
-Once you select an image you have the option to remove it.
Please review it, thanks