-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce relative coverage change info #40
base: main
Are you sure you want to change the base?
Conversation
3e7ff38
to
e70978a
Compare
Thanks for contributing, it's a great feature 💪 |
e70978a
to
2fb406a
Compare
Thanks for your positive feedback!
I like this idea! 👍 I'm going to adjust it accordingly. |
2fb406a
to
1a27779
Compare
@MishaKav Which of these two variants do you like more? I don't quite like the first variant because the text is not centered vertically along with the badge. |
I like more the second way, even this with space. I think another improvement may be to represent the Increased with some green icon (example 🟢) and Decreased with red icon (example 🔴) because they usually represent these metrics (but no sure, if it's better) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please update a README
and action.yaml
with example and a screesnhot?
This is some great work! |
Sorry, haven't been able to finish this over the last weeks! I'll try to do so this weekend 👍 |
Could I help in some way to get this over the line? |
Hmm thanks I had some different ideas for the final implementation, but I have to take a look at it again. I really intend to complete this pull request, hopefully I'll have time to do so this weekend 👍 |
This would be very nice to have :) |
this is a cool feature. Any updates on when this will be completed/merged? |
The report will now include information about the relative change in coverage when the previous coverage value is passed along with the file input.
For example, if the coverage info is stored in a gist (for the badge), this value can be read out and passed to this action.
ToDo:
Example with single file
■ Unchanged
Example with multiple files
▲ Increased (+18%)
▼ Decreased (-11%)