Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input for skipping full covered files from xml #186

Merged

Conversation

NikTerentev
Copy link
Contributor

@NikTerentev NikTerentev commented Oct 10, 2024

I am using this action for generate a report from xml coverage. After the project size increased, I started thinking about hiding 100 percent covered lines in this report. However, after studying the documentation, I found that hiding covered lines is not available. So i decided to add this feature manually.

Coverage itself does not have such functionality. Here is a comment from a Coverage developer about adding such functionality: PR. He suggested making changes specifically to the program that displays reports (in this case this action).

Here is an example before and after using the new parameter:

Before:

image

After:

image


Full covered file:

image

@@ -67,6 +67,7 @@ const main = async () => {
reportOnlyChangedFiles: false,
removeLinkFromBadge: false,
hideComment: false,
// xmlSkipCovered: true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why commented?

@MishaKav MishaKav changed the base branch from main to skipping-full-covered-files-from-xml October 10, 2024 19:31
@MishaKav MishaKav merged commit 0f80a93 into MishaKav:skipping-full-covered-files-from-xml Oct 10, 2024
1 check failed
MishaKav added a commit that referenced this pull request Oct 10, 2024
* Add input for skipping full covered files from xml (#186)

* formatting xml-skip-covered related files

* 1.1.53

* Add option to skip fully covered lines based on xml report

* Update @actions/core to version 1.11.1

* Update devDependencies in package.json

* update changelog

* Update dependabot configuration to allow minor and patch updates for npm development and production dependencies

---------

Co-authored-by: Nikita Terentyev <69214030+NikTerentev@users.noreply.github.com>
@MishaKav
Copy link
Owner

@NikTerentev Big thanks for such a great feature and implementation, just released a new version v1.1.53 with your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants