Dice so nice - Don't play dice sound twice #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description.
Currently, two dice sounds will play when dice so nice is enabled. One when the player tries to perform a roll, and one when the dice so nice dice start rolling. Detect if dice so nice is enabled, and if it is, disable the regular dice rolling sound.
Breaking change for current users that have dice so nice enabled. Now it will just play the dice so nice dice sounds. Maybe it should be put in the game settings configuration.
Motivation and Context.
Slightly annoying to hear 2 separate dice sounds.
Screenshots.
Types of Changes.