1289: Fixed issue with item value being taken from another item

[kwitczak]

Motivation and Context

The goal of this change was to fix a problem described in #1289 - skills in the Character sheet had different values when the sheet was in a locked vs unlocked state. That was happening for specialised skills named "Any", for example, "Pilot (Any)" or "Art/Craft (Any)".

Root cause

This problem is caused by the fact that we don't fully support skills with non-unique names.
Skills as items are stored in this.system.skills object, and there are two keys used to identify them:

• skillName
• id

And they live next to each other in the same object, this.system.skills.

In some cases, skillName is used to obtain a skill, in some cases it's id.
As a result, if two skills with the same name exist, their rawValue will be displayed correctly, while value will be taken from the this.system.skills by skillName, thus picking the last object that was saved with that non-unique key name, causing the problem.

Types of Changes

I feel id is a new thing and I don't know if using only this property (which would be best) won't break old systems...
So I added a method which, for a given item, should either store it using id or, if id does not exists, as skillName.
It's also used for obtaining the item the same way.

• Fixes Locked character sheet skill totals don't match the unlocked sheet or edited values #1289

Tests Done

• Adding a skill and rolling it
• Editing a skill and rolling it
• Adding occupation to a character and rolling these skills
• Doing battle roles and dodge rolls
• Doing creature rolls

Screenshots

[kwitczak]

@snap01 , @HavlockV I added quite a big description because I'm uncertain if this change won't break backwards-compatibility due to id usage and I'm slowly learning the system. I plan to do some more testing later during the week.

[kwitczak]

@snap01 I did some testing and it seems fine.