Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoC ID filtering by language #1435

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Fix CoC ID filtering by language #1435

merged 2 commits into from
Nov 12, 2023

Conversation

snap01
Copy link
Collaborator

@snap01 snap01 commented Nov 12, 2023 •
edited
Loading

Description.

  • CoC ID fix eraText if called with default (true)
  • Prevent trying to get best CoC D for any era
  • Fix both filtering methods

Motivation and Context.

This pull request was made in response to @Technus's Fix/optimize CoC ID filters #1418 as additional issues were found in the original implemention

Types of Changes.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

@snap01 snap01 mentioned this pull request Nov 12, 2023
Closed
3 tasks
@snap01 snap01 merged commit 8685ee1 into Miskatonic-Investigative-Society:develop Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snap01