Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing system.json grid values format #1564

Conversation

Vicnasc
Copy link
Contributor

@Vicnasc Vicnasc commented Jun 17, 2024

Description.

In FoundryVTT there's a warning that the fields gridDistance and gridUnit is deprecated in favor of a grid object with the distance and unit as inner fields. TemplateVersion is also getting a warning, but I'm not sure if its required for the system itself for documental purposes (couldn't find a version control over the code).

Motivation and Context.

It is not required, though may be useful for FoundryVTT's base guidelines.

Screenshots.

image

Types of Changes.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

@snap01
Copy link
Collaborator

snap01 commented Jun 18, 2024

The current system supports FoundryVTT back to v10, these values are kept for backwards compatibility. A future update is planned for v12 that will drop both v10 and v11 support which will allow these and several warnings in game to be removed.

@snap01 snap01 added the refactor Code change that neither fixes bugs nor adds features label Jun 18, 2024
@ceriath
Copy link

ceriath commented Jun 25, 2024

Heya, i noticed the warnings today too and wanted to provide but a fix, but there is one already here.
To get rid of the warning while maintaining backwards compatibility you may simply put both in the system.json, see dnd5e for example: https://github.com/foundryvtt/dnd5e/blob/3.3.x/system.json#L213

@Vicnasc
Copy link
Contributor Author

Vicnasc commented Jun 26, 2024

@snap01, thanks for the reply, my mistake for not looking at v10, only looked at v11

@ceriath, thanks for the suggestion, I applied the fix

@snap01 snap01 merged commit 17282cf into Miskatonic-Investigative-Society:develop Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code change that neither fixes bugs nor adds features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants