Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F3-2084: Apply clang-format #55

Closed
wants to merge 1 commit into from
Closed

F3-2084: Apply clang-format #55

wants to merge 1 commit into from

Conversation

hjoe72
Copy link

@hjoe72 hjoe72 commented Apr 26, 2024 •
edited
Loading

Apply clang-format. This prevents confusion for future PR review when modifying the code in this file when clang-format is enabled.

@hjoe72
Apply clang-format
d5d07a6 
Apply clang-format.
@hjoe72 hjoe72 requested a review from zzv2 April 26, 2024 22:39
@hjoe72 hjoe72 self-assigned this Apr 26, 2024
@hjoe72 hjoe72 requested a review from nardavin May 2, 2024 17:21
@hjoe72 hjoe72 marked this pull request as draft May 2, 2024 17:22
@hjoe72 hjoe72 marked this pull request as ready for review May 2, 2024 17:22
@hjoe72 hjoe72 added the refactor label May 2, 2024
zzv2
zzv2 requested changes May 3, 2024
View reviewed changes
Copy link

@zzv2 zzv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not apply clang-format since it will cause a bunch of merge conflicts if we ever want to try to pull from the upstream repo this was forked from

@hjoe72 hjoe72 closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzv2 zzv2 zzv2 requested changes

@nardavin nardavin Awaiting requested review from nardavin

Assignees

@hjoe72 hjoe72

Labels
enhancement flippy refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjoe72 @zzv2