Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F3-2084: Update USB cam param name #57

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

hjoe72
Copy link

@hjoe72 hjoe72 commented Jun 6, 2024

Update USB cameras param name.

@hjoe72 hjoe72 added the bug label Jun 6, 2024
@hjoe72 hjoe72 requested review from nardavin, zzv2 and dtamino June 6, 2024 01:52
@hjoe72 hjoe72 self-assigned this Jun 6, 2024
@github-actions github-actions bot added the flippy label Jun 6, 2024
Copy link

@zzv2 zzv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make it incompatible with the old cameras?

@hjoe72
Copy link
Author

hjoe72 commented Jun 7, 2024

does this make it incompatible with the old cameras?

Actually nevermind, this seems more related with the v4l2 version installed rather than camera specific. So I'm closing this for now since this is what works for Flippy

@hjoe72 hjoe72 closed this Jun 7, 2024
@hjoe72 hjoe72 reopened this Jul 2, 2024
@hjoe72 hjoe72 requested a review from zzv2 July 2, 2024 18:47
Copy link

@dtamino dtamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, new v4l2 driver versions changed the names of the parameters, or why the change?

@hjoe72
Copy link
Author

hjoe72 commented Jul 2, 2024

So, new v4l2 driver versions changed the names of the parameters, or why the change?

yes, it's the UVC driver version

Update USB cameras param name.
@zzv2 zzv2 force-pushed the user/hjoe72/fix/usb-cam-param branch from 0682927 to 68040e0 Compare July 2, 2024 21:06
@zzv2 zzv2 merged commit e55f04a into develop Jul 2, 2024
1 check passed
@zzv2 zzv2 deleted the user/hjoe72/fix/usb-cam-param branch July 2, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants