F3-5443: Add service for resetting the camera exposure #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzv2
approved these changes
Jul 16, 2024
nardavin
approved these changes
Jul 16, 2024
| @@ -414,6 +417,8 @@ class UsbCamNode | |||
| int main(int argc, char **argv) | |||
| { | |||
| ros::init(argc, argv, "usb_cam"); | |||
| ros::AsyncSpinner spinner{ 2 }; | |||
There was a problem hiding this comment.
Add some kind of note here that if we add another callback type without adding another thread, there could be weird threading issues
Add service for resetting camera exposure.
hjoe72
force-pushed
the
user/hjoe72/feature/srv-reset-cam
branch
from
cdc1720
to
13ad59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add service for resetting camera exposure.