Make snapshotting on KVM non-blocking #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one! Will keep an eye on it. |
|
Great work @bheuvel! |
rohityadavcloud
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Mar 12, 2019
This references and uses an already fixed solution from MissionCriticalCloud/cosmic#68 to make snapshotting on KVM non-blocking. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
5 tasks
rohityadavcloud
added a commit
to apache/cloudstack
that referenced
this pull request
Mar 25, 2019
* server: make snapshotting on KVM non-blocking This references and uses an already fixed solution from MissionCriticalCloud/cosmic#68 to make snapshotting on KVM non-blocking. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> * move StorageSubSystemCommand instanceof check above as CopyCommand is a type of StorageSubSystemCommand Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
pbankonier
pushed a commit
to pbankonier/cloudstack
that referenced
this pull request
Apr 24, 2019
* server: make snapshotting on KVM non-blocking This references and uses an already fixed solution from MissionCriticalCloud/cosmic#68 to make snapshotting on KVM non-blocking. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> * move StorageSubSystemCommand instanceof check above as CopyCommand is a type of StorageSubSystemCommand Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in the KVM guru seems to have this intent, but is never used if it doesn't return a
truevalue.In reponse to issue #12
Closes #12