Limit static route result to corresponding vpcId when a gwId is passed #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisroman
suggested changes
Oct 4, 2016
| private Long retrieveVpcId() { | ||
| if (gatewayId != null) { | ||
| final VpcGateway gateway = _vpcService.getVpcPrivateGateway(gatewayId); | ||
| return gateway.getVpcId(); |
There was a problem hiding this comment.
gateway can be null here when a non existing private gateway id has been used. Please review @remibergsma
There was a problem hiding this comment.
Thanks @borisroman will have a look at it
There was a problem hiding this comment.
@borisroman Invalid input is handled:
(local) 🐵 > list staticroutes gatewayid=9e037a7b-a2d6-4bc5-b2ae-65e3ab257801
Error 431: Unable to execute API command liststaticroutes due to invalid value. Invalid parameter gatewayid value=9e037a7b-a2d6-4bc5-b2ae-65e3ab257801 due to incorrect long value format, or entity does not exist or due to incorrect parameter annotation for the field in api cmd class.
remibergsma
force-pushed
the
fix/vpc-static-route-listing
branch
from
eb755f5
to
68a122c
Compare
|
go build |
1 similar comment
|
go build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a private
gatewayIdis passed, lookup itsVPCidand return only static routes that belong to this VPC.