Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor read info classes using a super class #173

Merged
merged 4 commits into from
May 16, 2017

Conversation

bheuvel
Copy link
Contributor

@bheuvel bheuvel commented May 4, 2017

Closes #172
Closes #150

Implement a super class, ReadTransportInfo, for ReadSSHInfo, ReadWinrmInfo and ReadRdpInfo.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8343f02 on refactor_read_info into ** on master**.

@bheuvel
Copy link
Contributor Author

bheuvel commented May 4, 2017

Running RSpec tests in folder : vmlifecycle
Using Vagrant file            : Vagrantfile.advanced_networking

VM Life Cycle
  starts Linux and Windows VM
  destroys Linux and Windows VM

Finished in 2 minutes 48.2 seconds (files took 0.13955 seconds to load)
2 examples, 0 failures

Running RSpec tests in folder : networking
Using Vagrant file            : Vagrantfile.advanced_networking

Networking features
  creates firewall and portwarding rules for both Virtual Router and VPC

Finished in 2 minutes 48.7 seconds (files took 0.09559 seconds to load)
1 example, 0 failures

Running RSpec tests in folder : rsync
Using Vagrant file            : Vagrantfile.advanced_networking

VM RSync
  does rsync to the VM

Finished in 49.84 seconds (files took 0.09467 seconds to load)
1 example, 0 failures

@MichielCuijpers
Copy link

Nice work @bheuvel you cleaned this #SpringCleaning issue. When this PR is accepted, please send your postal address to bettercodehub@sig.eu if you like to receive your book. Best Regards Michiel

@remibergsma remibergsma merged commit dfa42af into master May 16, 2017
@remibergsma remibergsma deleted the refactor_read_info branch May 16, 2017 10:16
@MichielCuijpers
Copy link

@bheuvel the book is on its way. Thanks for joining this years OpenSourceSpringCleaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants