Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use biome #823

Draft
wants to merge 1 commit into
base: io
Choose a base branch
from
Draft

use biome #823

wants to merge 1 commit into from

Conversation

u1-liquid
Copy link
Member

@u1-liquid u1-liquid commented Nov 24, 2024

What

現在の動作確認:ビルド・backendの起動

テスト前に以下のコマンドを2回実行する必要がある

pnpm biome check --write --unsafe --diagnostic-level=error

frontendはsafe fix適用するとぶっ壊れるのでデバッグが必要

  • achivement.tsでaccount.tsの$iに対してReferenceErrorが発生する
    TDN関連の問題だと思うけどどこがどうなってこうなるのかまだつかめてない

Why

いい加減formatter入れたい・eslintが遅すぎる

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

sonarcloud bot commented Nov 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant