Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActivityPub): URIとURLが一致しない場合、同じドメイン内のサブドメインの1階層の違いまでは許容する #859

Merged
merged 9 commits into from
Dec 28, 2024

Conversation

u1-liquid
Copy link
Member

@u1-liquid u1-liquid commented Dec 28, 2024

What

https://redirect.github.com/misskey-dev/misskey/issues/15039

Why

activitypub的に必ずこれらのidが完全一致のhost上に存在しなければならないという制約はないので、実際にthreadsやbrid.gyで別hostで運用されているusecaseがある以上対応したほうがいいとされている

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link
Collaborator

@riku6460 riku6460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActivityPub 全然わからんけどぱっと見で気になった部分

@u1-liquid
Copy link
Member Author

他に何かなければマージしちゃいたい

@u1-liquid u1-liquid merged commit 5433255 into MisskeyIO:io Dec 28, 2024
16 checks passed
@u1-liquid u1-liquid deleted the ap-subdomain-allow branch December 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants