Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excluding/including files #39

Open
Alloyed opened this issue May 16, 2016 · 2 comments
Open

excluding/including files #39

Alloyed opened this issue May 16, 2016 · 2 comments

Comments

@Alloyed
Copy link

Alloyed commented May 16, 2016

So #36 got me so I wanted to look through the source to figure out why and I saw this comment

-- @todo This function should be able to parse and use CVS files such as
-- gitignore. It should also work on the file tree rather than on the file list.

This is not what I'd want love-release to do, because the things I exclude from git are things like art and music that would bloat up the repo, and I don't think my game would be very good without art and music.

Possible alternate interface: have a love-release specific include/exclude list that just checks matches against normal lua patterns, so for example

t.releases.exclude = { "%.moon$" }

would exclude moonscript files and

t.releases.include = { "%.lua$", "^assets/" }

would only include either lua files or things in the assets dir

@MisterDA
Copy link
Owner

MisterDA commented May 17, 2016

Thanks ! This is a really good note. I didn't think about the fact you pointed out about git, and I agree with you. Your proposal on include/exclude is also a very good idea.

@TangentFoxy
Copy link

TangentFoxy commented Jun 22, 2018

Well the exclude half of this is implemented, but I can't help but notice the lack of include by pattern. Is there a reason behind that half not being implemented?

I would argue it is a good idea, I have a project where I'm excluding like 7 different file types during building, it'd be much easier to include .lua, .wav, and .png (the only file types that make up the completed game).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants