Exclude files #42
Exclude files #42
Conversation
|
Thank your for your involvement ! Everything seems good to me. Do you prefer a merge commit or a squash 'n merge ? I'm tempted by the squash. |
| rm = false | ||
| end | ||
| for i=#self._fileList,1,-1 do | ||
| if isExcluded(self._fileList[i], dir, unpack(self.excludeFileList)) then |
There was a problem hiding this comment.
I'd like an alias here to support multiple versions of Lua (see msg00532)
local unpack = unpack or table.unpack
-- or
table.unpack = table.unpack or unpack -- preferred ?
There was a problem hiding this comment.
Avoid the second one, you should never modify Lua's built-in modules since that is not expected from a module and can end up with problems in other modules later on
There was a problem hiding this comment.
No problem. I'm glad I'm following this project, it is already really mature. Keep it up!
|
Thanks for the review! I fixed the whitespace (you were right about the editor removing it) and shimmed the |
This accomplishes what I consider to be the more important half of #39, configuration of a file exclusion list.
The implementation is fairly straightforward except for my rewrite of
Project:excludeFiles. I couldn't figure out why it was written the way it was so if I've messed something up there, please let me know and I'll fix it.