Add check for external keyboard on iOS(iPad). Replaced bool status with KeyboardVisibilityStatus which extended with iOS external keyboard
#158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with `KeyboardVisibilityStatus` which extended with iOS external keyboard
muknta
commented
Apr 25, 2024
| flutter_keyboard_visibility_web: ^2.0.0 | ||
| flutter_keyboard_visibility_windows: ^1.0.0 | ||
| flutter_keyboard_visibility_platform_interface: | ||
| git: |
Author
There was a problem hiding this comment.
the reviewers have the ability to test it via current working pubspec dependencies.
After I get an approval for this PR, I will revert pubspec changes
Author
There was a problem hiding this comment.
@MisterJimson
also, if you are satisfied with general idea, I will update all places of the doc comments across the package to the status instead of isKeyboardVisible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
We needed a different behaviour for visible external keyboard from visible digital keyboard on iPad.
Currently, only iPad has a design for that (bottom touch bar). For iPhone there is nothing at the screen while external keyboard is active.
It looks like that:
