Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to change Content-Type #2647

Closed
PabloBarrachina opened this issue Dec 19, 2020 · 2 comments
Closed

Not able to change Content-Type #2647

PabloBarrachina opened this issue Dec 19, 2020 · 2 comments
Labels
Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec Type: Bug For bugs and any other unexpected breakage

Comments

@PabloBarrachina
Copy link

mithril.js/mithril.js

Line 1398 in 2b5c2f0

if (assumeJSON && body != null && !hasHeader(args, /^content0-type1$/i)) {

¿Is this a typo?
@pygy
Copy link
Member

pygy commented Jan 16, 2021

Great catch @PabloBarrachina this looks like a bundler bug, it is incredibly fickle (it is not using a proper parser, just a RegExp-based approximation of one).

@pygy pygy added Area: Core For anything dealing with Mithril core itself Type: Breaking Change For any feature request or suggestion that could reasonably break existing code Type: Bug For bugs and any other unexpected breakage Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec and removed Type: Breaking Change For any feature request or suggestion that could reasonably break existing code Area: Core For anything dealing with Mithril core itself labels Jan 16, 2021
@pygy
Copy link
Member

pygy commented Jan 16, 2021

I dread these bundler bugs...

I'd be tempted to rename the problematic variables, or to use the RegExp constructor to work around it...

pygy added a commit that referenced this issue Jan 16, 2021
@pygy
[m.request] work around a bundler bug, fix #2647
e9d54b5
@pygy pygy mentioned this issue Jan 16, 2021
Merged
11 tasks
StephanHoyer pushed a commit that referenced this issue May 16, 2022
@pygy @StephanHoyer
[m.request] work around a bundler bug, fix #2647
d25cf63
@dead-claudia dead-claudia moved this to Closed in Triage/bugs Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Workflow For anything dealing with Mithril's internal tooling, including the mocks and bundler, but not ospec Type: Bug For bugs and any other unexpected breakage
Projects
Triage/bugs
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pygy @PabloBarrachina