Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Flems example for Simple Application #2710

Closed
tbreuss opened this issue Oct 31, 2021 · 3 comments
Closed

Outdated Flems example for Simple Application #2710

tbreuss opened this issue Oct 31, 2021 · 3 comments
Assignees
Labels
Area: Documentation For anything dealing mainly with the documentation itself Type: Bug For bugs and any other unexpected breakage

Comments

@tbreuss
Copy link
Contributor

tbreuss commented Oct 31, 2021

The referenced Flems for the Simple Application on the website under https://mithril.js.org/simple-application.html in the second paragraph "An interactive example of the end result can be seen here" is using Mithril version 1.1.6.

This is quite misleading or confusing when reading the simple application guide and comparing code snippets.

This is the referenced Flems link.

The Mithril dependency in Flems is https://unpkg.com/mithril@1.1.6/mithril.js.

As a solution we should migrate the Flems example to version 2.0.4 and then update the link as described above.

@tbreuss tbreuss added the Type: Bug For bugs and any other unexpected breakage label Oct 31, 2021
@tbreuss
Copy link
Contributor Author

tbreuss commented Nov 1, 2021

Have a working 2.0.4 version at https://mithril-by-examples.tebe.ch/examples/simple-application/. The Flems link could be copied from there.

@StephanHoyer
Copy link
Member

@tbreuss can you create a PR that fixes this?

@StephanHoyer StephanHoyer added the Area: Documentation For anything dealing mainly with the documentation itself label Feb 21, 2022
@tbreuss
Copy link
Contributor Author

tbreuss commented Feb 22, 2022

@StephanHoyer See my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Documentation For anything dealing mainly with the documentation itself Type: Bug For bugs and any other unexpected breakage
Projects
Status: Closed
Development

No branches or pull requests

3 participants