Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simple Application Flems Supporting v2.0.4 and up #2751

Merged

Conversation

tbreuss
Copy link
Contributor

@tbreuss tbreuss commented Feb 22, 2022

Added Flems for Simple Application supporting v2.0.4 of Mithril.js

Fixes Issue #2710

@StephanHoyer
Copy link
Member

StephanHoyer commented Feb 23, 2022

@tbreuss would you want to extend the auto-flemsify to support multiple files, and then inline the example into the docs?

https://github.com/MithrilJS/mithril.js/pull/2348/files#diff-303cc9b044e3d851bbc83fdf87d831f0e76128ec657c3ec9291ef189e6cc820dR44-R77

@tbreuss
Copy link
Contributor Author

tbreuss commented Feb 23, 2022

I deleted my last comment, since I get the idea now.

@tbreuss would you want to extend the auto-flemsify to support multiple files, and then inline the example into the docs?

That is a nice idea, and I would try to do this, since embedding Flems links is really not ideal.

But: I think, this has to be clearly discussed first, since files have to be grouped in some way. In addition to that, there is maybe the need of requiring external packages, too?

Anyway, I will first go through linked code to understand how things work.

@StephanHoyer
Copy link
Member

how about

// UserModel.js
...

// UserList.js
...

// UserForm.js
...

// Layout.js
...

// app.js
...

// .css
...

// mithril.js - https://unpkg.com/mithril@[version]/mithril.js
// someLib.js - https://unpkg.com/someLib/index.js

@StephanHoyer
Copy link
Member

@tbreuss any plans in doing this? If not, I will merge this and we do this with the docs overhaul

@tbreuss
Copy link
Contributor Author

tbreuss commented Mar 1, 2022

@StephanHoyer Since due to my holidays I won't be able to work on it until next week and not everything is 100% clear I would recommend to merge this first. After that we can discuss and do some improvements.

Please note that I have removed the explicit Mithril.js 2.0.4 requirement, and just requiring mitrhil.js without version now. See the second commit.

@StephanHoyer StephanHoyer changed the title Add Simple Application Flems Supporting v2.0.4 Add Simple Application Flems Supporting v2.0.4 and up Mar 1, 2022
@StephanHoyer StephanHoyer merged commit 53bedd1 into MithrilJS:next Mar 1, 2022
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants