m.route.Link doesn't proxy event handler prevention

[barneycarroll]

m.route.Link documentation misleadingly states that

You can also prevent navigation by, in an onclick handler, invoking ev.preventDefault() or returning false. This is the same way you block other events, so it's pretty natural.

Neither of those criteria will actually prevent the default behaviour of a Link as they do with a simple a. It's a shame because this is IMO the clearest sentence in this APIs documentation, and it's false. I wrote a little matrix sandbox to try and work out how event handling logic intersected with Link behaviour here, it may be useful for anyone else trying to reconcile expectations.

It took me reading the source & returning to read the docs a few times over to realise they're trying to explain the behaviour of a special-cased magic disabled attribute, which is the only way of preventing an Link from resolving. On that front, they're extremely unclear. Critically, the published docs have a typo stating that the disabled attribute is forwarded to the m.route.set API.

[barneycarroll]

As a priority, the docs need fixing to remove the misleading line about event handlers & fix the API signature table's description of disabled. That can close this bug IMO.

[pygy]

The router has been completely rewritten since I left, and I'll have to wrap my head around the new code first if we decide something needs fixing

[StephanHoyer]

Do you think it's a release blocker? I was planning to release this weekend 😉

Can anyone fix the docs for now so we can do bugfix release later on?

[pygy]

@barneycarroll can you do it? I've yet to wrap my head around the issue, and I have the kids this weekend. I may have a look at it this evening otherwise.