Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSFiddle links are broken in CI #2898

Closed
dead-claudia opened this issue Jul 29, 2024 · 4 comments
Closed

JSFiddle links are broken in CI #2898

dead-claudia opened this issue Jul 29, 2024 · 4 comments
Labels
Area: Documentation For anything dealing mainly with the documentation itself Type: Bug For bugs and any other unexpected breakage

Comments

@dead-claudia
Copy link
Member

Example pull request: #2897

They're returning 403s, so we need to investigate to see how we can auto-confirm their existence. Might be worth getting an API token from them or at least confirming with their support how best to proceed.
@dead-claudia dead-claudia added Area: Documentation For anything dealing mainly with the documentation itself Type: Bug For bugs and any other unexpected breakage labels Jul 29, 2024
@devshDotTech

This comment has been minimized.

Sign in to view
dead-claudia added a commit that referenced this issue Aug 25, 2024
@dead-claudia
Tolerate docs failures
7cf72ff 
This way, pull requests are no longer blocked by #2898
@dead-claudia
Copy link
Member Author

Got an open inquiry for JSFiddle: jsfiddle/jsfiddle-users#1876

@dead-claudia dead-claudia mentioned this issue Aug 25, 2024
Merged
11 tasks
dead-claudia added a commit that referenced this issue Aug 25, 2024
@dead-claudia
Migrate to Node 20, clean up workflows (#2902)
9d9e0e7 
Tests still appear to fail per #2898. Unfortunately, I need actions/runner#2347 to ignore the test failures properly - I need them to be warnings, not hard errors.
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 1, 2024
@dead-claudia
Partially rewrite docs linter
7f2e8a3 
1. I want to set the stage to deal with MithrilJS#2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.

I also decided to go a few steps further:
- Task queues to control concurrency
- Reimplemented the lint recursion manually
- Drop the cache to simplify everything
- Upgrade to a more modern language version
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 1, 2024
@dead-claudia
Partially rewrite docs linter
1e174e7 
1. I want to set the stage to deal with MithrilJS#2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.

I also decided to go a few steps further:
- Task queues to control concurrency
- Reimplemented the lint recursion manually
- Drop the cache to simplify everything
- Upgrade to a more modern language version
@dead-claudia dead-claudia mentioned this issue Sep 1, 2024
Merged
11 tasks
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 2, 2024
@dead-claudia
Rewrite docs linter
5611367 
1. I want to set the stage to deal with MithrilJS#2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.
3. `glob` was outdated, and it's easier to just toss it than to upgrade
   across a major version.
4. I switched to using Marked's "lexer" directly so I'm not fussing
   with the complexity of renderers. This of course necessitated a more
   complex file processor as its "lexer" is really an AST parser.

I also decided to go a few steps further:
- Drop the cache to simplify everything. I might reverse this later,
  but just caching URLs per-page should be enough to prevent the world
  from crashing down.
- Drop some more dependencies, so I don't have to come back to this
  later nearly as quickly.
- Upgrade to a more modern language version in the scripts.
- Update Marked. It was super outdated.
- Add line and column numbers to the warnings. That took quite a bit of
  work, thanks to a missing Marked feature plus a bug in Marked.
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 2, 2024
@dead-claudia
Rewrite docs linter
7d285b2 
1. I want to set the stage to deal with MithrilJS#2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.
3. `glob` was outdated, and it's easier to just toss it than to upgrade
   across a major version.
4. I switched to using Marked's "lexer" directly so I'm not fussing
   with the complexity of renderers. This of course necessitated a more
   complex file processor as its "lexer" is really an AST parser.

I also decided to go a few steps further:
- Drop the cache to simplify everything. I might reverse this later,
  but just caching URLs per-page should be enough to prevent the world
  from crashing down.
- Drop some more dependencies, so I don't have to come back to this
  later nearly as quickly.
- Upgrade to a more modern language version in the scripts.
- Update Marked. It was super outdated.
- Add line and column numbers to the warnings. That took quite a bit of
  work, thanks to a missing Marked feature plus a bug in Marked.
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 2, 2024
@dead-claudia
Rewrite docs linter
a4f92b2 
1. I want to set the stage to deal with MithrilJS#2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.
3. `glob` was outdated, and it's easier to just toss it than to upgrade
   across a major version.
4. I switched to using Marked's "lexer" directly so I'm not fussing
   with the complexity of renderers. This of course necessitated a more
   complex file processor as its "lexer" is really an AST parser.

I also decided to go a few steps further:
- Drop the cache to simplify everything. I might reverse this later,
  but just caching URLs per-page should be enough to prevent the world
  from crashing down.
- Drop some more dependencies, so I don't have to come back to this
  later nearly as quickly.
- Upgrade to a more modern language version in the scripts.
- Update Marked. It was super outdated.
- Add line and column numbers to the warnings. That took quite a bit of
  work, thanks to a missing Marked feature plus a bug in Marked.
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 2, 2024
@dead-claudia
Rewrite docs linter
053a9d7 
1. I want to set the stage to deal with MithrilJS#2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.
3. `glob` was outdated, and it's easier to just toss it than to upgrade
   across a major version.
4. I switched to using Marked's "lexer" directly so I'm not fussing
   with the complexity of renderers. This of course necessitated a more
   complex file processor as its "lexer" is really an AST parser.

I also decided to go a few steps further:
- Drop the cache to simplify everything. I might reverse this later,
  but just caching URLs per-page should be enough to prevent the world
  from crashing down.
- Drop some more dependencies, so I don't have to come back to this
  later nearly as quickly.
- Upgrade to a more modern language version in the scripts.
- Update Marked. It was super outdated.
- Add line and column numbers to the warnings. That took quite a bit of
  work, thanks to a missing Marked feature plus a bug in Marked.
dead-claudia added a commit that referenced this issue Sep 2, 2024
@dead-claudia
Rewrite docs linter
182b2e9 
1. I want to set the stage to deal with #2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.
3. `glob` was outdated, and it's easier to just toss it than to upgrade
   across a major version.
4. I switched to using Marked's "lexer" directly so I'm not fussing
   with the complexity of renderers. This of course necessitated a more
   complex file processor as its "lexer" is really an AST parser.

I also decided to go a few steps further:
- Drop the cache to simplify everything. I might reverse this later,
  but just caching URLs per-page should be enough to prevent the world
  from crashing down.
- Drop some more dependencies, so I don't have to come back to this
  later nearly as quickly.
- Upgrade to a more modern language version in the scripts.
- Update Marked. It was super outdated.
- Add line and column numbers to the warnings. That took quite a bit of
  work, thanks to a missing Marked feature plus a bug in Marked.
@dead-claudia
Copy link
Member Author

Appears to be a false positive based on #2904. I suspect I may have gotten bot-limited by it due to excessive (and highly avoidable) request concurrency.

@dead-claudia
Copy link
Member Author

Okay, #2906 should remove what little else could potentially spam websites outside of directly throttling network requests.

dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 23, 2024
@dead-claudia
Tolerate docs failures
2b687a3 
This way, pull requests are no longer blocked by MithrilJS#2898
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 23, 2024
@dead-claudia
Migrate to Node 20, clean up workflows (MithrilJS#2902)
1b0899b 
Tests still appear to fail per MithrilJS#2898. Unfortunately, I need actions/runner#2347 to ignore the test failures properly - I need them to be warnings, not hard errors.
dead-claudia added a commit to dead-claudia/mithril.js that referenced this issue Sep 23, 2024
@dead-claudia
Rewrite docs linter
0d095d1 
1. I want to set the stage to deal with MithrilJS#2898 properly.
2. `request` was deprecated years ago. Decided that it's better to just
   move to native Node.js APIs in its place.
3. `glob` was outdated, and it's easier to just toss it than to upgrade
   across a major version.
4. I switched to using Marked's "lexer" directly so I'm not fussing
   with the complexity of renderers. This of course necessitated a more
   complex file processor as its "lexer" is really an AST parser.

I also decided to go a few steps further:
- Drop the cache to simplify everything. I might reverse this later,
  but just caching URLs per-page should be enough to prevent the world
  from crashing down.
- Drop some more dependencies, so I don't have to come back to this
  later nearly as quickly.
- Upgrade to a more modern language version in the scripts.
- Update Marked. It was super outdated.
- Add line and column numbers to the warnings. That took quite a bit of
  work, thanks to a missing Marked feature plus a bug in Marked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Documentation For anything dealing mainly with the documentation itself Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dead-claudia @devshDotTech