Remove m.prop + m.withAttr
#2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-claudia
added
Type: Breaking Change
| @@ -365,8 +365,14 @@ var Login = { | |||
| login: function() {/*...*/}, | |||
| view: function() { | |||
| return m(".login", [ | |||
| m("input[type=text]", {oninput: m.withAttr("value", this.setUsername.bind(this)), value: this.username}), | |||
| m("input[type=password]", {oninput: m.withAttr("value", this.setPassword.bind(this)), value: this.password}), | |||
There was a problem hiding this comment.
Good grief, what a mess this was. A large part of the beauty of closures by default will be removing all these horrid custom component methods and this references.
| @@ -383,7 +383,10 @@ var Form = { | |||
| }, | |||
| view: function() { | |||
| return m("form", [ | |||
| m("input[placeholder='Search']", {oninput: m.withAttr("value", function(v) {state.term = v}), value: state.term}), | |||
There was a problem hiding this comment.
Mind-boggling this was seen as useful at the time.
dead-claudia
force-pushed
the
remove-utils
branch
2 times, most recently
from
e2cb189 to
a02a910
Compare
- For many uses, `m.withAttr` is *more* verbose than just directly using an event handler - If you're using it with a bound callback, you're literally wasting a single character in the human readable version (and you're *saving* them in the minified output). - It sometimes obscures your intent, if overused. - Functions are easier to compress than `m.withAttr`, resulting in slightly smaller bundles. - `m.withAttr` is overused anyways. - `m.prop` is basically useless without `m.withAttr`, and the API doesn't have the same benefits it had with 0.2.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
m.withAttris more verbose than just directly using an event handlerm.withAttr, resulting in slightly smaller bundles.m.withAttris overused anyways.m.propis basically useless withoutm.withAttr, and the API doesn't have the same benefits it had with 0.2.x.See the corresponding docs changes to see what I mean.
Motivation and Context
Spawned from a Gitter conversation starting approximately here (and continued for a few hours). Also, look at the changes to the docs, and that should also show why I'd like to make the change.
How Has This Been Tested?
Ran
npm testand everything worked as usual. The linter errors are unrelated.Types of changes
Checklist:
docs/change-log.md