Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add params: to m.route.Link, fix docs #2537

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Add params: to m.route.Link, fix docs #2537

merged 1 commit into from
Sep 30, 2019

Conversation

dead-claudia
Copy link
Member

@dead-claudia dead-claudia commented Sep 30, 2019 •
edited
Loading

Description

  • Add params: to m.route.Link
  • Minor fix to docs to reflect reality with m.route.Link's disabled: attribute
  • Minor source formatting tweak to signature table for m.route.Link.

Motivation and Context

Fixes #2477

How Has This Been Tested?

Added a new test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@dead-claudia dead-claudia added Type: Bug For bugs and any other unexpected breakage Area: Documentation For anything dealing mainly with the documentation itself Type: Enhancement For any feature request or suggestion that isn't a bug fix Area: Core For anything dealing with Mithril core itself labels Sep 30, 2019
@dead-claudia dead-claudia merged commit 3fa1630 into MithrilJS:next Sep 30, 2019
@dead-claudia dead-claudia deleted the link-params branch September 30, 2019 21:16
@felix-roehrich
Copy link

I encountered this problem a few days ago and found that there is already an issue. Any idea, when this will be released ? This was already merged almost 2 years ago but still has not shipped yet.
I can find a workaround, but I think it is weird that this is still not released.

@JAForbes JAForbes mentioned this pull request Apr 28, 2022
Merged
@orbitbot orbitbot added the minor label May 1, 2022
StephanHoyer pushed a commit that referenced this pull request May 16, 2022
@dead-claudia @StephanHoyer
Add params: to m.route.Link, fix docs (#2537)
b6898d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Core For anything dealing with Mithril core itself Area: Documentation For anything dealing mainly with the documentation itself minor Type: Bug For bugs and any other unexpected breakage Type: Enhancement For any feature request or suggestion that isn't a bug fix
Projects
Triage/bugs
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing implementation of URL templates with m.route.Link
3 participants
@dead-claudia @felix-roehrich @orbitbot