Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace slave label with replica #2605

Merged
merged 1 commit into from
Jun 19, 2020
Merged

replace slave label with replica #2605

merged 1 commit into from
Jun 19, 2020

Conversation

stephanos
Copy link
Contributor

Description

One of the example is using the antiquated word "slave" for a database replica. I updated the language and tested the change.

Motivation and Context

If possible, I'd like to live in a world where we avoid that word.

How Has This Been Tested?

I've tested the example on my local machine and it seems to work perfectly fine:

Screen Shot 2020-06-19 at 08 06 50

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@stephanos stephanos requested a review from dead-claudia as a code owner June 19, 2020 15:08
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll accept it as databases are moving to that terminology anyways (and I would prefer to stay consistent with their idioms above all else).

@dead-claudia dead-claudia merged commit dca44b1 into MithrilJS:next Jun 19, 2020
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
StephanHoyer pushed a commit that referenced this pull request May 16, 2022
Co-authored-by: Stephan Behnke <git@stephanbehnke.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants