Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2624 no content 204 parse #2641

Merged

Conversation

Evoke-PHP
Copy link
Contributor

Description

Added guard so that JSON.parse does not fail on IE11 with no content empty string being parsed.

Motivation and Context

Fixes #2624

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

@StephanHoyer StephanHoyer merged commit 4351f62 into MithrilJS:next Jan 25, 2022
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
@orbitbot orbitbot added the patch label May 1, 2022
StephanHoyer pushed a commit that referenced this pull request May 16, 2022
Co-authored-by: Paul Young <paul.young@northpoint.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Request with 204 no-content response causes syntax error in IE11
4 participants