Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated babel/webpack docs to work with latest versions #2649

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

pereriksson
Copy link
Contributor

Description

As a developer I tried setting up Mithril with Babel and Webpack but failed because of a variety of errors. After some research I have adjusted the documentation so that works with the latest versions.

Motivation and Context

Following the documentation does not lead to a working environment based on the latest versions. The guide needs to provide a working set of instructions.

How Has This Been Tested?

The updated instructions have been run in a clean environment and tested on a small Mithril/JSX codebase.
Babel 7.12.10
Webpack 5.11.1
Mithril 2.0.4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

@StephanHoyer StephanHoyer merged commit d93cca9 into MithrilJS:next Feb 18, 2022
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants